Use the newest go vet

The newest go vet based on go/analysis

Author: jirfag

.golangci.example.yml

@@ -81,6 +81,15 @@ linters-settings:
   govet:
     # report about shadowed variables
     check-shadowing: true
+
+    # settings per analyzer
+    settings:
+      printf: # analyzer name, run `go tool vet help` to see all analyzers
+        funcs: # run `go tool vet help printf` to see available settings for `printf` analyzer
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
   golint:
     # minimal confidence for issues, default is 0.8
     min-confidence: 0.8

.golangci.yml

@@ -1,6 +1,13 @@
 linters-settings:
   govet:
     check-shadowing: true
+    settings:
+      printf:
+        funcs:
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
   golint:
     min-confidence: 0
   gocyclo:
@@ -42,6 +49,7 @@ linters:
 run:
   skip-dirs:
     - test/testdata_etc
+    - pkg/golinters/goanalysis/(checker|passes)
 
 issues:
   exclude-rules:

Makefile

@@ -1,8 +1,8 @@
 test:
 	go build -o golangci-lint ./cmd/golangci-lint
 	GL_TEST_RUN=1 ./golangci-lint run -v
-	GL_TEST_RUN=1 ./golangci-lint run --fast --no-config -v --skip-dirs test/testdata_etc
-	GL_TEST_RUN=1 ./golangci-lint run --no-config -v --skip-dirs test/testdata_etc
+	GL_TEST_RUN=1 ./golangci-lint run --fast --no-config -v --skip-dirs 'test/testdata_etc,pkg/golinters/goanalysis/(checker|passes)'
+	GL_TEST_RUN=1 ./golangci-lint run --no-config -v --skip-dirs 'test/testdata_etc,pkg/golinters/goanalysis/(checker|passes)'
 	GL_TEST_RUN=1 go test -v ./...
 
 test_race:

README.md

@@ -185,7 +185,7 @@ GolangCI-Lint can be used with zero configuration. By default the following lint
 ```bash
 $ golangci-lint help linters
 Enabled by default linters:
-govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]
+govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: false, auto-fix: false]
 errcheck: Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: true, auto-fix: false]
 staticcheck: Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: false, auto-fix: false]
 unused: Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
@@ -612,6 +612,15 @@ linters-settings:
   govet:
     # report about shadowed variables
     check-shadowing: true
+
+    # settings per analyzer
+    settings:
+      printf: # analyzer name, run `go tool vet help` to see all analyzers
+        funcs: # run `go tool vet help printf` to see available settings for `printf` analyzer
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
   golint:
     # minimal confidence for issues, default is 0.8
     min-confidence: 0.8
@@ -785,6 +794,13 @@ than the default and have more strict settings:
 linters-settings:
   govet:
     check-shadowing: true
+    settings:
+      printf:
+        funcs:
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
   golint:
     min-confidence: 0
   gocyclo:
@@ -826,6 +842,7 @@ linters:
 run:
   skip-dirs:
     - test/testdata_etc
+    - pkg/golinters/goanalysis/(checker|passes)
 
 issues:
   exclude-rules:

go.mod

@@ -19,7 +19,6 @@ require (
 	github.com/golangci/gocyclo v0.0.0-20180528134321-2becd97e67ee
 	github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98
 	github.com/golangci/gosec v0.0.0-20180901114220-66fb7fc33547
-	github.com/golangci/govet v0.0.0-20180818181408-44ddbe260190
 	github.com/golangci/ineffassign v0.0.0-20180808204949-2ee8f2867dde
 	github.com/golangci/lint-1 v0.0.0-20180610141402-4bf9709227d1
 	github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca
@@ -52,7 +51,7 @@ require (
 	golang.org/x/crypto v0.0.0-20190313024323-a1f597ede03a // indirect
 	golang.org/x/net v0.0.0-20190313220215-9f648a60d977 // indirect
 	golang.org/x/sys v0.0.0-20190312061237-fead79001313 // indirect
-	golang.org/x/tools v0.0.0-20190314010720-1286b2016bb1
+	golang.org/x/tools v0.0.0-20190314010720-f0bfdbff1f9c
 	gopkg.in/airbrake/gobrake.v2 v2.0.9 // indirect
 	gopkg.in/gemnasium/logrus-airbrake-hook.v2 v2.1.2 // indirect
 	gopkg.in/yaml.v2 v2.2.1

go.sum

@@ -58,8 +58,6 @@ github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98 h1:ir6/L2ZOJfFrJlOT
 github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98/go.mod h1:9qCChq59u/eW8im404Q2WWTrnBUQKjpNYKMbU4M7EFU=
 github.com/golangci/gosec v0.0.0-20180901114220-66fb7fc33547 h1:qMomh8bv+kDazm1dSLZ9S3zZ2PJZMHL4ilfBjxFOlmI=
 github.com/golangci/gosec v0.0.0-20180901114220-66fb7fc33547/go.mod h1:0qUabqiIQgfmlAmulqxyiGkkyF6/tOGSnY2cnPVwrzU=
-github.com/golangci/govet v0.0.0-20180818181408-44ddbe260190 h1:SLIgprnxQNjBpkz55PK1vfb64/gKU/TgVi0obFw8Lec=
-github.com/golangci/govet v0.0.0-20180818181408-44ddbe260190/go.mod h1:pPwb+AK755h3/r73avHz5bEN6sa51/2HEZlLaV53hCo=
 github.com/golangci/ineffassign v0.0.0-20180808204949-2ee8f2867dde h1:qEGp3ZF1Qw6TkbWKn6GdJ12Ssu/CpJBaBcJ4hrUjrSo=
 github.com/golangci/ineffassign v0.0.0-20180808204949-2ee8f2867dde/go.mod h1:e5tpTHCfVze+7EpLEozzMB3eafxo2KT5veNg1k6byQU=
 github.com/golangci/lint-1 v0.0.0-20180610141402-4bf9709227d1 h1:PHK2kIh21Zt4IcG0bBRzQwEDVKF64LnkoSXnm8lfJUk=
@@ -146,8 +144,6 @@ github.com/spf13/viper v1.0.2 h1:Ncr3ZIuJn322w2k1qmzXDnkLAdQMlJqBa9kfAH+irso=
 github.com/spf13/viper v1.0.2/go.mod h1:A8kyI5cUJhb8N+3pkfONlcEcZbueH6nhAm0Fq7SrnBM=
 github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
 github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
-golang.org/x/crypto v0.0.0-20180505025534-4ec37c66abab h1:w4c/LoOA2vE8SYwh8wEEQVRUwpph7TtcjH7AtZvOjy0=
-golang.org/x/crypto v0.0.0-20180505025534-4ec37c66abab/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20190313024323-a1f597ede03a h1:YX8ljsm6wXlHZO+aRz9Exqr0evNhKRNe5K/gi+zKh4U=
 golang.org/x/crypto v0.0.0-20190313024323-a1f597ede03a/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
@@ -173,10 +169,8 @@ golang.org/x/tools v0.0.0-20180221164845-07fd8470d635/go.mod h1:n7NCudcB/nEzxVGm
 golang.org/x/tools v0.0.0-20181117154741-2ddaf7f79a09/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20181205014116-22934f0fdb62/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20190121143147-24cd39ecf745/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
-golang.org/x/tools v0.0.0-20190125232054-379209517ffe h1:ZJ3JgA0fnPnX6nSjHp3y5XWNUf3zaTbWlilINJoPFkQ=
-golang.org/x/tools v0.0.0-20190125232054-379209517ffe/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
-golang.org/x/tools v0.0.0-20190314010720-1286b2016bb1 h1:bVqQ31OV9908eHt6CNzw09jKOqi34qHsp4nsinaxiuw=
-golang.org/x/tools v0.0.0-20190314010720-1286b2016bb1/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=
+golang.org/x/tools v0.0.0-20190314010720-f0bfdbff1f9c h1:nE2ID2IbO0sUUG/3vWMz0LStAvkaW9wpnFp/65bxJw8=
+golang.org/x/tools v0.0.0-20190314010720-f0bfdbff1f9c/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=
 gopkg.in/airbrake/gobrake.v2 v2.0.9 h1:7z2uVWwn7oVeeugY1DtlPAy5H+KYgB1KeKTnqjNatLo=
 gopkg.in/airbrake/gobrake.v2 v2.0.9/go.mod h1:/h5ZAUhDkGaJfjzjKLSjv6zCL6O0LLBxU4K+aSYdM/U=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

pkg/commands/executor.go

@@ -39,7 +39,7 @@ func NewExecutor(version, commit, date string) *Executor {
 		version:   version,
 		commit:    commit,
 		date:      date,
-		DBManager: lintersdb.NewManager(),
+		DBManager: lintersdb.NewManager(nil),
 	}
 
 	e.log = report.NewLogWrapper(logutils.NewStderrLog(""), &e.reportData)
@@ -82,6 +82,9 @@ func NewExecutor(version, commit, date string) *Executor {
 		e.log.Fatalf("Can't read config: %s", err)
 	}
 
+	// recreate after getting config
+	e.DBManager = lintersdb.NewManager(e.cfg)
+
 	e.cfg.LintersSettings.Gocritic.InferEnabledChecks(e.log)
 	if err := e.cfg.LintersSettings.Gocritic.Validate(e.log); err != nil {
 		e.log.Fatalf("Invalid gocritic settings: %s", err)

pkg/commands/run.go

@@ -278,7 +278,8 @@ func (e *Executor) runAnalysis(ctx context.Context, args []string) (<-chan resul
 	}
 	lintCtx.Log = e.log.Child("linters context")
 
-	runner, err := lint.NewRunner(lintCtx.ASTCache, e.cfg, e.log.Child("runner"), e.goenv, e.lineCache)
+	runner, err := lint.NewRunner(lintCtx.ASTCache, e.cfg, e.log.Child("runner"),
+		e.goenv, e.lineCache, e.DBManager)
 	if err != nil {
 		return nil, err
 	}

pkg/config/config.go

@@ -121,9 +121,7 @@ type Run struct {
 }
 
 type LintersSettings struct {
-	Govet struct {
-		CheckShadowing bool `mapstructure:"check-shadowing"`
-	}
+	Govet  GovetSettings
 	Golint struct {
 		MinConfidence float64 `mapstructure:"min-confidence"`
 	}
@@ -173,6 +171,11 @@ type LintersSettings struct {
 	Gocritic GocriticSettings
 }
 
+type GovetSettings struct {
+	CheckShadowing bool `mapstructure:"check-shadowing"`
+	Settings       map[string]map[string]interface{}
+}
+
 type ErrcheckSettings struct {
 	CheckTypeAssertions bool   `mapstructure:"check-type-assertions"`
 	CheckAssignToBlank  bool   `mapstructure:"check-blank"`

pkg/golinters/goanalysis/linter.go

@@ -0,0 +1,137 @@
+package goanalysis
+
+import (
+	"context"
+	"flag"
+	"fmt"
+	"strings"
+
+	"github.com/pkg/errors"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis/checker"
+	"github.com/golangci/golangci-lint/pkg/lint/linter"
+	"github.com/golangci/golangci-lint/pkg/result"
+)
+
+type Linter struct {
+	name, desc string
+	analyzers  []*analysis.Analyzer
+	cfg        map[string]map[string]interface{}
+}
+
+func NewLinter(name, desc string, analyzers []*analysis.Analyzer, cfg map[string]map[string]interface{}) *Linter {
+	return &Linter{name: name, desc: desc, analyzers: analyzers, cfg: cfg}
+}
+
+func (lnt Linter) Name() string {
+	return lnt.name
+}
+
+func (lnt Linter) Desc() string {
+	return lnt.desc
+}
+
+func (lnt Linter) allAnalyzerNames() []string {
+	var ret []string
+	for _, a := range lnt.analyzers {
+		ret = append(ret, a.Name)
+	}
+	return ret
+}
+
+func allFlagNames(fs *flag.FlagSet) []string {
+	var ret []string
+	fs.VisitAll(func(f *flag.Flag) {
+		ret = append(ret, f.Name)
+	})
+	return ret
+}
+
+func valueToString(v interface{}) string {
+	if ss, ok := v.([]string); ok {
+		return strings.Join(ss, ",")
+	}
+
+	if is, ok := v.([]interface{}); ok {
+		var ss []string
+		for _, i := range is {
+			ss = append(ss, fmt.Sprint(i))
+		}
+		return valueToString(ss)
+	}
+
+	return fmt.Sprint(v)
+}
+
+func (lnt Linter) configureAnalyzer(a *analysis.Analyzer, cfg map[string]interface{}) error {
+	for k, v := range cfg {
+		f := a.Flags.Lookup(k)
+		if f == nil {
+			validFlagNames := allFlagNames(&a.Flags)
+			if len(validFlagNames) == 0 {
+				return fmt.Errorf("analyzer doesn't have settings")
+			}
+
+			return fmt.Errorf("analyzer doesn't have setting %q, valid settings: %v",
+				k, validFlagNames)
+		}
+
+		if err := f.Value.Set(valueToString(v)); err != nil {
+			return errors.Wrapf(err, "failed to set analyzer setting %q with value %v", k, v)
+		}
+	}
+
+	return nil
+}
+
+func (lnt Linter) configure() error {
+	analyzersMap := map[string]*analysis.Analyzer{}
+	for _, a := range lnt.analyzers {
+		analyzersMap[a.Name] = a
+	}
+
+	for analyzerName, analyzerSettings := range lnt.cfg {
+		a := analyzersMap[analyzerName]
+		if a == nil {
+			return fmt.Errorf("settings key %q must be valid analyzer name, valid analyzers: %v",
+				analyzerName, lnt.allAnalyzerNames())
+		}
+
+		if err := lnt.configureAnalyzer(a, analyzerSettings); err != nil {
+			return errors.Wrapf(err, "failed to configure analyzer %s", analyzerName)
+		}
+	}
+
+	return nil
+}
+
+func (lnt Linter) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issue, error) {
+	if err := analysis.Validate(lnt.analyzers); err != nil {
+		return nil, errors.Wrap(err, "failed to validate analyzers")
+	}
+
+	if err := lnt.configure(); err != nil {
+		return nil, errors.Wrap(err, "failed to configure analyzers")
+	}
+
+	diags, errs := checker.Run(lnt.analyzers, lintCtx.Packages)
+	for i := 1; i < len(errs); i++ {
+		lintCtx.Log.Warnf("%s error: %s", lnt.Name(), errs[i])
+	}
+	if len(errs) != 0 {
+		return nil, errs[0]
+	}
+
+	var issues []result.Issue
+	for _, diag := range diags {
+		i := result.Issue{
+			FromLinter: lnt.Name(),
+			Text:       fmt.Sprintf("%s: %s", diag.AnalyzerName, diag.Message),
+			Pos:        diag.Position,
+		}
+		issues = append(issues, i)
+	}
+
+	return issues, nil
+}