Add filen linter (#5081)

Co-authored-by: Fernandez Ludovic <[email protected]>

Author: DanilXO

.golangci.next.reference.yml

@@ -36,6 +36,7 @@ linters:
     - exhaustruct
     - exportloopref
     - fatcontext
+    - filen
     - forbidigo
     - forcetypeassert
     - funlen
@@ -152,6 +153,7 @@ linters:
     - exhaustruct
     - exportloopref
     - fatcontext
+    - filen
     - forbidigo
     - forcetypeassert
     - funlen
@@ -534,6 +536,17 @@ linters-settings:
     exclude:
       - '.+/cobra\.Command$'
 
+  filen:
+    # Ignore comments when counting lines.
+    # Default false
+    ignore-comments: true
+    # Max number of lines in a file.
+    # Default: 1000
+    max-lines: 500
+    # Min number of lines in a file.
+    # Default: 5
+    min-lines: 1
+
   forbidigo:
     # Forbid the following identifiers (list of regexp).
     # Default: ["^(fmt\\.Print(|f|ln)|print|println)$"]

go.mod

@@ -12,6 +12,7 @@ require (
 	github.com/Antonboom/testifylint v1.5.0
 	github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c
 	github.com/Crocmagnon/fatcontext v0.5.2
+	github.com/DanilXO/filen v0.3.0
 	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
 	github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0
 	github.com/OpenPeeDeeP/depguard/v2 v2.2.0

go.sum

@@ -1012,6 +1012,27 @@
             }
           }
         },
+        "filen": {
+          "type": "object",
+          "additionalProperties": false,
+          "properties": {
+            "ignore-comments": {
+              "description": "Ignore comments when counting lines.",
+              "type": "boolean",
+              "default": false
+            },
+            "max-lines": {
+              "description": "Max number of lines in a file.",
+              "type": "integer",
+              "default": 1000
+            },
+            "min-lines": {
+              "description": "Min number of lines in a file.",
+              "type": "integer",
+              "default": 5
+            }
+          }
+        },
         "forbidigo": {
           "type": "object",
           "additionalProperties": false,

jsonschema/golangci.next.jsonschema.json

@@ -40,6 +40,11 @@ var defaultLintersSettings = LintersSettings{
 		ExplicitExhaustiveMap:      false,
 		ExplicitExhaustiveSwitch:   false,
 	},
+	Filen: FilenSettings{
+		MinLines:       5,
+		MaxLines:       1000,
+		IgnoreComments: false,
+	},
 	Forbidigo: ForbidigoSettings{
 		ExcludeGodocExamples: true,
 	},
@@ -214,6 +219,7 @@ type LintersSettings struct {
 	ErrorLint       ErrorLintSettings
 	Exhaustive      ExhaustiveSettings
 	Exhaustruct     ExhaustructSettings
+	Filen           FilenSettings
 	Forbidigo       ForbidigoSettings
 	Funlen          FunlenSettings
 	Gci             GciSettings
@@ -418,6 +424,12 @@ type ExhaustructSettings struct {
 	Exclude []string `mapstructure:"exclude"`
 }
 
+type FilenSettings struct {
+	IgnoreComments bool `mapstructure:"ignore-comments"`
+	MaxLines       int  `mapstructure:"max-lines"`
+	MinLines       int  `mapstructure:"min-lines"`
+}
+
 type ForbidigoSettings struct {
 	Forbid               []ForbidigoPattern `mapstructure:"forbid"`
 	ExcludeGodocExamples bool               `mapstructure:"exclude-godoc-examples"`

pkg/config/linters_settings.go

@@ -0,0 +1,24 @@
+package filen
+
+import (
+	"github.com/DanilXO/filen/pkg/filen"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/goanalysis"
+)
+
+func New(settings *config.FilenSettings) *goanalysis.Linter {
+	a := filen.NewAnalyzer(&filen.Runner{
+		MaxLines:       settings.MaxLines,
+		MinLines:       settings.MinLines,
+		IgnoreComments: settings.IgnoreComments,
+	})
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/filen/filen.go

@@ -0,0 +1,11 @@
+package filen
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}