Skip to content

Commit 1c6caf1

Browse files
shaunthegeekldez
authored andcommitted
fix: code climate report need severity
1 parent 9a592fb commit 1c6caf1

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

pkg/printers/codeclimate.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ func (p CodeClimate) Print(ctx context.Context, issues []result.Issue) error {
4040
codeClimateIssue.Location.Path = issue.Pos.Filename
4141
codeClimateIssue.Location.Lines.Begin = issue.Pos.Line
4242
codeClimateIssue.Fingerprint = issue.Fingerprint()
43+
codeClimateIssue.Severity = "critical"
4344

4445
if issue.Severity != "" {
4546
codeClimateIssue.Severity = issue.Severity

pkg/printers/codeclimate_test.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,21 @@ func TestCodeClimate_Print(t *testing.T) {
4242
Column: 9,
4343
},
4444
},
45+
{
46+
FromLinter: "linter-c",
47+
Text: "issue c",
48+
SourceLines: []string{
49+
"func foo() {",
50+
"\tfmt.Println(\"ccc\")",
51+
"}",
52+
},
53+
Pos: token.Position{
54+
Filename: "path/to/filec.go",
55+
Offset: 6,
56+
Line: 200,
57+
Column: 2,
58+
},
59+
},
4560
}
4661

4762
buf := new(bytes.Buffer)
@@ -51,7 +66,7 @@ func TestCodeClimate_Print(t *testing.T) {
5166
require.NoError(t, err)
5267

5368
//nolint:lll
54-
expected := `[{"description":"linter-a: some issue","severity":"warning","fingerprint":"BA73C5DF4A6FD8462FFF1D3140235777","location":{"path":"path/to/filea.go","lines":{"begin":10}}},{"description":"linter-b: another issue","severity":"error","fingerprint":"0777B4FE60242BD8B2E9B7E92C4B9521","location":{"path":"path/to/fileb.go","lines":{"begin":300}}}]`
69+
expected := `[{"description":"linter-a: some issue","severity":"warning","fingerprint":"BA73C5DF4A6FD8462FFF1D3140235777","location":{"path":"path/to/filea.go","lines":{"begin":10}}},{"description":"linter-b: another issue","severity":"error","fingerprint":"0777B4FE60242BD8B2E9B7E92C4B9521","location":{"path":"path/to/fileb.go","lines":{"begin":300}}},{"description":"linter-c: issue c","severity":"critical","fingerprint":"BEE6E9FBB6BFA4B7DB9FB036697FB036","location":{"path":"path/to/filec.go","lines":{"begin":200}}}]`
5570

5671
assert.Equal(t, expected, buf.String())
5772
}

0 commit comments

Comments
 (0)