go1.22 support (#4272)

Author: ldez

.github/workflows/documentation.yml

@@ -11,7 +11,7 @@ jobs:
     name: Build and deploy documentation
     runs-on: ubuntu-latest
     env:
-      GO_VERSION: '1.21'
+      GO_VERSION: '1.22'
       NODE_VERSION: '20.x'
       CGO_ENABLED: 0
 

.github/workflows/post-release.yml

@@ -18,7 +18,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: '1.21'
+          go-version: '1.22'
 
       - name: Update GitHub action config
         run: make assets/github-action-config.json

.github/workflows/pr-documentation.yml

@@ -9,7 +9,7 @@ jobs:
     name: Build documentation
     runs-on: ubuntu-latest
     env:
-      GO_VERSION: '1.21'
+      GO_VERSION: '1.22'
       NODE_VERSION: '20.x'
       CGO_ENABLED: 0
 

.github/workflows/pr-extra.yml

@@ -17,7 +17,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: '1.21'
+          go-version: '1.22'
       - name: Run go list
         run: go list -json -m all > go.list
       - name: Nancy

.github/workflows/pr.yml

@@ -6,7 +6,7 @@ on:
   pull_request:
 
 env:
-  GO_VERSION: '1.21'
+  GO_VERSION: '1.22'
 
 jobs:
   # Check if there is any dirty change for go mod tidy
@@ -42,7 +42,9 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: ${{ env.GO_VERSION }}
+          # TODO(ldez) must be changed after the first release of golangci-lint with go1.22
+          # go-version: ${{ env.GO_VERSION }}
+          go-version: '1.21'
       - name: lint
         uses: golangci/[email protected]
         with:
@@ -89,8 +91,8 @@ jobs:
     strategy:
       matrix:
         golang:
-          - '1.20'
           - '1.21'
+          - '1.22'
     steps:
       - uses: actions/checkout@v4
       - name: Install Go

.github/workflows/tag.yml

@@ -16,7 +16,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: '1.21'
+          go-version: '1.22'
       - name: Unshallow
         run: git fetch --prune --unshallow
 
@@ -46,7 +46,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: '1.21'
+          go-version: '1.22'
 
       - name: Unshallow
         run: git fetch --prune --unshallow

build/Dockerfile

@@ -1,5 +1,5 @@
 # stage 1 building the code
-FROM golang:1.21 as builder
+FROM golang:1.22 as builder
 
 ARG VERSION
 ARG SHORT_COMMIT
@@ -12,7 +12,7 @@ RUN APP_VERSION=${VERSION#v} \
     go build -trimpath -ldflags "-s -w -X main.version=$APP_VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
 
 # stage 2
-FROM golang:1.21
+FROM golang:1.22
 # related to https://github.com/golangci/golangci-lint/issues/3107
 ENV GOROOT /usr/local/go
 # Set all directories as safe

build/alpine.Dockerfile

@@ -1,5 +1,5 @@
 # stage 1 building the code
-FROM golang:1.21-alpine as builder
+FROM golang:1.22-alpine as builder
 
 ARG VERSION
 ARG SHORT_COMMIT
@@ -17,7 +17,7 @@ RUN APP_VERSION=${VERSION#v} \
     go build -trimpath -ldflags "-s -w -X main.version=$APP_VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
 
 # stage 2
-FROM golang:1.21-alpine
+FROM golang:1.22-alpine
 # related to https://github.com/golangci/golangci-lint/issues/3107
 ENV GOROOT /usr/local/go
 # gcc is required to support cgo;

go.mod

@@ -1,6 +1,6 @@
 module github.com/golangci/golangci-lint
 
-go 1.20
+go 1.21
 
 require (
 	4d63.com/gocheckcompilerdirectives v1.2.1

go.sum

@@ -41,13 +41,13 @@ type Version struct {
 	Debug  bool   `mapstructure:"debug"`
 }
 
-func IsGreaterThanOrEqualGo121(v string) bool {
+func IsGreaterThanOrEqualGo122(v string) bool {
 	v1, err := hcversion.NewVersion(strings.TrimPrefix(v, "go"))
 	if err != nil {
 		return false
 	}
 
-	limit, err := hcversion.NewVersion("1.21")
+	limit, err := hcversion.NewVersion("1.22")
 	if err != nil {
 		return false
 	}

pkg/config/config.go

@@ -5,12 +5,12 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"slices"
 	"strings"
 
 	"github.com/go-viper/mapstructure/v2"
 	"github.com/mitchellh/go-homedir"
 	"github.com/spf13/viper"
-	"golang.org/x/exp/slices"
 
 	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/fsutils"

pkg/config/reader.go

@@ -1,9 +1,9 @@
 package golinters
 
 import (
+	"slices"
 	"testing"
 
-	"golang.org/x/exp/slices"
 	"golang.org/x/tools/go/analysis"
 	"golang.org/x/tools/go/analysis/passes/asmdecl"
 	"golang.org/x/tools/go/analysis/passes/assign"

pkg/golinters/govet_test.go

@@ -134,7 +134,7 @@ func (lc *Config) Name() string {
 }
 
 func (lc *Config) WithNoopFallback(cfg *config.Config) *Config {
-	if cfg != nil && config.IsGreaterThanOrEqualGo121(cfg.Run.Go) {
+	if cfg != nil && config.IsGreaterThanOrEqualGo122(cfg.Run.Go) {
 		lc.Linter = &Noop{
 			name: lc.Linter.Name(),
 			desc: lc.Linter.Desc(),

pkg/lint/linter/config.go

@@ -2,12 +2,11 @@ package test
 
 import (
 	"fmt"
+	"slices"
 	"sort"
 	"strings"
 	"testing"
 
-	"golang.org/x/exp/slices"
-
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
 	"github.com/golangci/golangci-lint/test/testshared"
 )

test/enabled_linters_test.go

@@ -3,10 +3,10 @@ package zerologlint
 
 import (
 	"fmt"
+	"slices"
 
 	"github.com/rs/zerolog"
 	"github.com/rs/zerolog/log"
-	"golang.org/x/exp/slices"
 )
 
 func expectWarnings() {