address review comments

Signed-off-by: yeya24 <[email protected]>

Author: yeya24

.golangci.example.yml

@@ -348,11 +348,11 @@ linters-settings:
     range-loops: true # Report preallocation suggestions on range loops, true by default
     for-loops: false # Report preallocation suggestions on for loops, false by default
   promlinter:
-    # Promlinter cannot infer all metrics name in static analysis. Enable strict mode
-    # will also include the errors caused by failing to parse the args.
+    # Promlinter cannot infer all metrics name in static analysis.
+    # Enable strict mode will also include the errors caused by failing to parse the args.
     strict: false
-    disabled-linters:
     # Please refer to https://github.com/yeya24/promlinter#usage for detailed usage.
+    disabled-linters:
     #  - "Help"
     #  - "MetricUnits"
     #  - "Counter"

go.mod

@@ -80,7 +80,7 @@ require (
 	github.com/ultraware/whitespace v0.0.4
 	github.com/uudashr/gocognit v1.0.1
 	github.com/valyala/quicktemplate v1.6.3
-	github.com/yeya24/promlinter v0.0.0-20210328235706-000c7d74ddb3
+	github.com/yeya24/promlinter v0.1.0
 	golang.org/x/tools v0.1.0
 	gopkg.in/yaml.v2 v2.4.0
 	honnef.co/go/tools v0.1.3

go.sum

@@ -70,5 +70,5 @@ func NewPromlinter() *goanalysis.Linter {
 		}
 	}).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue {
 		return resIssues
-	}).WithLoadMode(goanalysis.LoadModeNone)
+	}).WithLoadMode(goanalysis.LoadModeSyntax)
 }

pkg/golinters/promlinter.go

@@ -480,6 +480,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle, linter.PresetModule).
 			WithURL("https://github.com/ldez/gomoddirectives"),
 		linter.NewConfig(golinters.NewPromlinter()).
+			WithSince("v1.40.0").
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/yeya24/promlinter"),
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives

pkg/lint/lintersdb/manager.go

@@ -8,26 +8,26 @@ import (
 
 var (
 	_ = promauto.NewCounterVec(
-		prometheus.CounterOpts{ // Metric: test_metric_name Error: counter metrics should have "_total" suffix
+		prometheus.CounterOpts{ // ERROR `Metric: test_metric_name Error: counter metrics should have "_total" suffix`
 			Name: "test_metric_name",
 			Help: "test help text",
 		}, []string{},
 	)
 
 	_ = promauto.NewCounterVec(
-		prometheus.CounterOpts{ // Metric: test_metric_total Error: no help text
+		prometheus.CounterOpts{ // ERROR "Metric: test_metric_total Error: no help text"
 			Name: "test_metric_total",
 		}, []string{},
 	)
 
 	_ = promauto.NewCounterVec(
-		prometheus.CounterOpts{ // Metric: metric_type_in_name_counter_total Error: metric name should not include type 'counter'
+		prometheus.CounterOpts{ // ERROR `Metric: metric_type_in_name_counter_total Error: metric name should not include type 'counter'`
 			Name: "metric_type_in_name_counter_total",
 			Help: "foo",
 		}, []string{},
 	)
 
-	_ = prometheus.NewHistogram(prometheus.HistogramOpts{ // Metric: test_duration_milliseconds Error: use base unit "seconds" instead of "milliseconds"
+	_ = prometheus.NewHistogram(prometheus.HistogramOpts{ // ERROR `Metric: test_duration_milliseconds Error: use base unit "seconds" instead of "milliseconds"`
 		Name: "test_duration_milliseconds",
 		Help: "",
 	})