Skip to content

Does not work on go 1.23 #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
mskonovalov opened this issue Aug 16, 2024 · 3 comments
Closed
3 tasks done

Does not work on go 1.23 #1086

mskonovalov opened this issue Aug 16, 2024 · 3 comments
Labels
question Further information is requested

Comments

@mskonovalov
Copy link

mskonovalov commented Aug 16, 2024

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Description of the problem

Since yesterday our CI step started to fail. With no error messages, simply hanging forever.
Looking into logs it seems we now have go 1.23. And the last working commit was using 1.22
Not sure yet what could be the exact issue (will update my findings) but for now it just does not work completely

Version of golangci-lint

1.59.1

Version of the GitHub Action

v6

Workflow file

  golangci:
    runs-on: ubuntu-latest
    timeout-minutes: 5

    steps:
      - name: Checkout the repository
        uses: actions/checkout@v4
      - uses: actions/setup-go@v5
        with:
          go-version: stable
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v6
        with:
          version: v1.59

Golangci-lint configuration

linters:
  # use all the default linters, plus the following
  enable:
    - goimports

Go version

1.23

Code example or link to a public repository

// add your code here
@mskonovalov
Copy link
Author

OK, golangci/golangci-lint#4837
TBH not sure if there is anything that the action can do here.
Maybe it is possible to add check if go is 1.23 and lint is < 1.60 to print meaningful error message

@ldez ldez added the question Further information is requested label Aug 16, 2024
@ldez ldez closed this as completed Aug 16, 2024
@mskonovalov
Copy link
Author

Just a tiny update:
it seems for 1.60.1 and go 1.23 it also does not work

  golangci:
    runs-on: ubuntu-latest
    timeout-minutes: 5

    steps:
      - name: Checkout the repository
        uses: actions/checkout@v4
      - uses: actions/setup-go@v5
        with:
          go-version: '1.23.0'
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v6
        with:
          version: v1.60.1

I guess it is becuase of golangci/golangci-lint#4908 (comment)

@ldez
Copy link
Member

ldez commented Aug 20, 2024

It's not related: in the issue, I talk about a custom build of golangci-lint with go1.22.
You are using the official version built with go1.23.

You can add extra information if you have a reproducible context, logs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants