Skip to content

tools: require tools update if the tool was compiled with older versions of Go #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyangah opened this issue Jan 5, 2022 · 1 comment
Assignees
Labels
FrozenDueToAge release-blocker must be fixed before the next release.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 5, 2022

In order to process generics and go1.18 features correctly, many tools must be compiled with go1.18.

Logic would be

  • find a tool's version by running go version -m or tool's version command.
  • if a tool was compiled with a newer or the same minor version of go, we are good.
  • if a tool was compiled with an older version of go, suggest update.
  • if go version -m fails to run:
    • the tool was compiled with a very ancient version of go(go1.12 or older?): don't suggest update.
    • the tool was compiled with a newer version of go: don't suggest update.
@hyangah hyangah added this to the v0.31.0 milestone Jan 5, 2022
@hyangah hyangah modified the milestones: v0.31.0, v0.32.0 Jan 18, 2022
@hyangah hyangah added the go1.18 label Jan 26, 2022
@hyangah hyangah added the release-blocker must be fixed before the next release. label Feb 8, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/385181 mentions this issue: src/goMain: suggest tool updates if tools were compiled with old go

@hyangah hyangah self-assigned this Mar 3, 2022
@golang golang locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge release-blocker must be fixed before the next release.
Projects
None yet
Development

No branches or pull requests

2 participants