src/goExplorer.ts: consolidate tools information into single tree item

For #2049

Change-Id: Idc23f0b10263d1988a1a20fe619a6a8ebc73b2d2
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391255
Trust: Jamal Carvalho <[email protected]>
Run-TryBot: Jamal Carvalho <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>

Author: jamalc

src/goExplorer.ts

@@ -216,10 +216,9 @@ class ToolTreeItem implements vscode.TreeItem {
 	constructor({ name, version, goVersion, binPath, error }: ToolDetail) {
 		this.label = name;
 		if (binPath) {
-			this.collapsibleState = vscode.TreeItemCollapsibleState.Collapsed;
-			this.children = [new ToolDetailTreeItem(binPath, goVersion)];
-			this.description = version;
-			this.tooltip = `${name}@${version}`;
+			this.label = `${name}@${version}`;
+			this.description = `${replaceHome(binPath)} ${goVersion}`;
+			this.tooltip = `${this.label} ${this.description}`;
 		}
 		if (error) {
 			const msg = `go version -m failed: ${error}`;
@@ -233,18 +232,6 @@ function isToolTreeItem(item?: vscode.TreeItem): item is ToolTreeItem {
 	return item?.contextValue === 'go:explorer:toolitem';
 }
 
-class ToolDetailTreeItem implements vscode.TreeItem {
-	contextValue = 'go:explorer:tooldetail';
-	label: string;
-	description: string;
-	tooltip: string;
-	constructor(bin: string, goVersion: string) {
-		this.label = replaceHome(bin);
-		this.description = goVersion;
-		this.tooltip = `${bin} ${goVersion}`;
-	}
-}
-
 interface ToolDetail {
 	name: string;
 	goVersion?: string;

test/integration/goExplorer.test.ts

@@ -56,9 +56,11 @@ suite('GoExplorerProvider', () => {
 		const expectTools = allTools.map((t) => t.name);
 		const [, tools] = await explorer.getChildren();
 		const items = (await explorer.getChildren(tools)) as TreeItem[];
-		assert.deepStrictEqual(
-			items.map((t) => t.label),
-			expectTools
-		);
+		for (const idx in items) {
+			assert(
+				items[idx].label.toString().startsWith(expectTools[idx]),
+				`Unexpected tool tree item with label "${items[idx].label}"`
+			);
+		}
 	});
 });