Skip to content

Commit af9afa3

Browse files
committed
src/goMain.ts: remove warning about dlv-dap in alternateTools
Change-Id: Ic43419cc2843d7f7fec00b00235bf63de7d620ac Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/385180 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Suzy Mueller <[email protected]>
1 parent bdcd7a6 commit af9afa3

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

src/goMain.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,6 @@ If you would like additional configuration for diagnostics from gopls, please se
182182
}
183183
}
184184

185-
// Present a warning about the deprecation of a 'dlv-dap' binary setting.
186-
checkAlternateTools(cfg);
187-
188185
updateGoVarsFromConfig().then(async () => {
189186
suggestUpdates(ctx);
190187
offerToInstallLatestGoVersion();
@@ -989,23 +986,3 @@ export async function setGOROOTEnvVar(configGOROOT: string) {
989986
delete process.env.GOROOT;
990987
}
991988
}
992-
993-
async function checkAlternateTools(goConfig: vscode.WorkspaceConfiguration) {
994-
const alternateTools = goConfig ? goConfig['alternateTools'] : {};
995-
// TODO(hyangah): delete this check after 2022-03-01.
996-
if (alternateTools['dlv-dap']) {
997-
const msg = `The extension no longer requires a separate 'dlv-dap' binary but uses the 'dlv' binary.
998-
The "dlv-dap" property of the "go.alternateTools" setting will be ignored.
999-
Please use the "dlv" property if you need to override the default Go debugger.`;
1000-
1001-
const selected = await vscode.window.showWarningMessage(msg, 'Open settings.json');
1002-
if (selected === 'Open settings.json') {
1003-
const { workspaceValue } = goConfig.inspect('alternateTools.dlv-dap');
1004-
if (workspaceValue !== undefined) {
1005-
vscode.commands.executeCommand('workbench.action.openWorkspaceSettingsFile');
1006-
} else {
1007-
vscode.commands.executeCommand('workbench.action.openSettingsJson');
1008-
}
1009-
}
1010-
}
1011-
}

0 commit comments

Comments
 (0)