package.json: disable go.installDependenciesWhenBuilding by default

If the GOROOT is not writable, any go build that triggers rebuild/reinstall
of std packages will fail if `-i` flag is given. Since go1.10, the flag
`-i` is unnecessary if the main purpose of it is to improve caching.

VS Code Go kept using this `-i` flag by default in GOPATH mode only
because `github.com/mdempsky/gocode` may still depend on it. Now more
users started to pick up gopls and Go modules are getting more widely
adopted, let's switch this problematic default.

Fixes #568

Change-Id: Ib1a9531ce213c6880fa046355e53eecef6575a5e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/251263
Reviewed-by: Rebecca Stambler <[email protected]>

Author: hyangah

docs/settings.md

@@ -244,9 +244,9 @@ Default: `false`
 
 ### `go.installDependenciesWhenBuilding`
 
-If true, then `-i` flag will be passed to `go build` everytime the code is compiled.
+If true, then `-i` flag will be passed to `go build` everytime the code is compiled. Since Go 1.10, setting this may be unnecessary unless you are in GOPATH mode and do not use the language server.
 
-Default: `true`
+Default: `false`
 
 ### `go.languageServerExperimentalFeatures`
 

package.json

@@ -1174,8 +1174,8 @@
         },
         "go.installDependenciesWhenBuilding": {
           "type": "boolean",
-          "default": true,
-          "description": "If true, then `-i` flag will be passed to `go build` everytime the code is compiled.",
+          "default": false,
+          "description": "If true, then `-i` flag will be passed to `go build` everytime the code is compiled. Since Go 1.10, setting this may be unnecessary unless you are in GOPATH mode and do not use the language server.",
           "scope": "resource"
         },
         "go.lintOnSave": {