2655 Function calls via delve 'call' are not supported

Author: ekulabuhov

src/debugAdapter/goDebug.ts

@@ -149,6 +149,7 @@ interface DebugThread {
 	pc: number;
 	goroutineID: number;
 	function?: DebugFunction;
+	ReturnValues: DebugVariable[];
 }
 
 interface StacktraceOut {
@@ -1572,21 +1573,63 @@ export class GoDebugSession extends LoggingDebugSession {
 
 	protected evaluateRequest(response: DebugProtocol.EvaluateResponse, args: DebugProtocol.EvaluateArguments): void {
 		log('EvaluateRequest');
-		this.evaluateRequestImpl(args).then(
-			(out) => {
-				const variable = this.delve.isApiV1 ? <DebugVariable>out : (<EvalOut>out).Variable;
-				// #2326: Set the fully qualified name for variable mapping
-				variable.fullyQualifiedName = variable.name;
-				response.body = this.convertDebugVariableToProtocolVariable(variable);
+		const re = new RegExp(/\w+(?=\(.*\))/, 'g');
+		if (re.test(args.expression)) {
+			this.evaluateCallImpl(args).then(out => {
+				const state = this.delve.isApiV1 ? <DebuggerState>out : (<CommandOut>out).State;
+				response.body = this.convertDebugVariableToProtocolVariable(state.currentThread.ReturnValues[0]);
 				this.sendResponse(response);
-				log('EvaluateResponse');
-			},
-			(err) => {
-				this.sendErrorResponse(response, 2009, 'Unable to eval expression: "{e}"', {
-					e: err.toString()
+				log('EvaluateCallResponse');
+			}, err => {
+				this.sendErrorResponse(response, 2009, 'Unable to complete call: "{e}"', { e: err.toString() });
+			});
+		} else {
+			this.evaluateRequestImpl(args).then(
+				(out) => {
+					const variable = this.delve.isApiV1 ? <DebugVariable>out : (<EvalOut>out).Variable;
+					// #2326: Set the fully qualified name for variable mapping
+					variable.fullyQualifiedName = variable.name;
+					response.body = this.convertDebugVariableToProtocolVariable(variable);
+					this.sendResponse(response);
+					log('EvaluateResponse');
+				},
+				(err) => {
+					this.sendErrorResponse(response, 2009, 'Unable to eval expression: "{e}"', {
+						e: err.toString()
+					});
+				}
+			);
+		}
+	}
+
+	private evaluateCallImpl(args: DebugProtocol.EvaluateArguments): Thenable<DebuggerState | CommandOut> {
+		// default to the topmost stack frame of the current goroutine
+		let goroutineId = -1;
+		let frameId = 0;
+		// args.frameId won't be specified when evaluating global vars
+		if (args.frameId) {
+			[goroutineId, frameId] = this.stackFrameHandles.get(args.frameId);
+		}
+		const scope = {
+			goroutineID: goroutineId,
+			frame: frameId
+		};
+		const evalSymbolArgs = this.delve.isApiV1 ? {
+			symbol: args.expression,
+			scope
+		} : {
+				Expr: args.expression,
+				Scope: scope,
+				Cfg: this.delve.loadConfig,
+				Unsafe: true
+			};
+		const returnValue = this.delve.callPromise<DebuggerState | CommandOut>('Command',
+			[{ name: 'call', returnInfoLoadConfig: this.delve.loadConfig, expr: evalSymbolArgs.Expr, unsafe: false, goroutineID: scope.goroutineID }]).then(val => val,
+				err => {
+					logError('Failed to call function: ', JSON.stringify(evalSymbolArgs.Expr, null, ' '), '\n\rCall error:', err.toString());
+					return Promise.reject(err);
 				});
-			}
-		);
+		return returnValue;
 	}
 
 	protected setVariableRequest(