Skip to content

Commit f3a1686

Browse files
committed
internal/lsp/source: add more go/analysis/passes analyzers to LSP's suite
The LSP already supports a bunch of analyses we have less confidence in than the vet suite so we should add these too. Updates golang/go#36639 Change-Id: Ifc37d09e3acd73de021be7b45b3d80fe8c00e0d7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215677 Run-TryBot: Michael Matloob <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 4320446 commit f3a1686

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

internal/lsp/source/options.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,20 @@ import (
2020
"golang.org/x/tools/go/analysis/passes/cgocall"
2121
"golang.org/x/tools/go/analysis/passes/composite"
2222
"golang.org/x/tools/go/analysis/passes/copylock"
23+
"golang.org/x/tools/go/analysis/passes/deepequalerrors"
24+
"golang.org/x/tools/go/analysis/passes/errorsas"
2325
"golang.org/x/tools/go/analysis/passes/httpresponse"
2426
"golang.org/x/tools/go/analysis/passes/loopclosure"
2527
"golang.org/x/tools/go/analysis/passes/lostcancel"
2628
"golang.org/x/tools/go/analysis/passes/nilfunc"
29+
"golang.org/x/tools/go/analysis/passes/nilness"
2730
"golang.org/x/tools/go/analysis/passes/printf"
31+
"golang.org/x/tools/go/analysis/passes/shadow"
2832
"golang.org/x/tools/go/analysis/passes/shift"
2933
"golang.org/x/tools/go/analysis/passes/sortslice"
3034
"golang.org/x/tools/go/analysis/passes/stdmethods"
3135
"golang.org/x/tools/go/analysis/passes/structtag"
36+
"golang.org/x/tools/go/analysis/passes/testinggoroutine"
3237
"golang.org/x/tools/go/analysis/passes/tests"
3338
"golang.org/x/tools/go/analysis/passes/unmarshal"
3439
"golang.org/x/tools/go/analysis/passes/unreachable"
@@ -472,6 +477,7 @@ var defaultAnalyzers = map[string]*analysis.Analyzer{
472477
cgocall.Analyzer.Name: cgocall.Analyzer,
473478
composite.Analyzer.Name: composite.Analyzer,
474479
copylock.Analyzer.Name: copylock.Analyzer,
480+
errorsas.Analyzer.Name: errorsas.Analyzer,
475481
httpresponse.Analyzer.Name: httpresponse.Analyzer,
476482
loopclosure.Analyzer.Name: loopclosure.Analyzer,
477483
lostcancel.Analyzer.Name: lostcancel.Analyzer,
@@ -487,5 +493,9 @@ var defaultAnalyzers = map[string]*analysis.Analyzer{
487493
unusedresult.Analyzer.Name: unusedresult.Analyzer,
488494

489495
// Non-vet analyzers
490-
sortslice.Analyzer.Name: sortslice.Analyzer,
496+
deepequalerrors.Analyzer.Name: deepequalerrors.Analyzer,
497+
nilness.Analyzer.Name: nilness.Analyzer,
498+
shadow.Analyzer.Name: shadow.Analyzer,
499+
sortslice.Analyzer.Name: sortslice.Analyzer,
500+
testinggoroutine.Analyzer.Name: testinggoroutine.Analyzer,
491501
}

0 commit comments

Comments
 (0)