go/analysis/passes/tests: break out of loop when we find a method

ianlancetaylor · ianlancetaylor · commit cc8e56e55e70 · 2019-03-22T16:28:07.000Z
Updates golang/go#30971 Change-Id: I7c9250c46fede553689cdc5007b6f330a006b867 Reviewed-on: https://go-review.googlesource.com/c/tools/+/168804 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/go/analysis/passes/tests/tests.go b/go/analysis/passes/tests/tests.go
@@ -152,6 +152,7 @@ func checkExample(pass *analysis.Pass, fn *ast.FuncDecl) {
 		for _, obj := range objs {
 			if obj, _, _ := types.LookupFieldOrMethod(obj.Type(), true, obj.Pkg(), mmbr); obj != nil {
 				found = true
+				break
 			}
 		}
 		if !found {

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,7 @@ func checkExample(pass analysis.Pass, fn ast.FuncDecl) {`
`152`	`152`	`for _, obj := range objs {`
`153`	`153`	`if obj, _, _ := types.LookupFieldOrMethod(obj.Type(), true, obj.Pkg(), mmbr); obj != nil {`
`154`	`154`	`found = true`
	`155`	`+ break`
`155`	`156`	`}`
`156`	`157`	`}`
`157`	`158`	`if !found {`