Skip to content

Commit c099dff

Browse files
committed
gopls/internal/vulncheck: log progress
Log before/after package loading and govulncheck.Source calls. All stderr output of `gopls vulncheck` command is forwarded to the client as LSP progress reports and visible to users. go/packages.Load can be traced further if GOPACKAGESDEBUG env var is set. Instrumentation in govulncheck.Source is still under discussion in upstream. For golang/go#56795 Change-Id: I8244930494aed17b319887bf96c2523f3215fa50 Reviewed-on: https://go-review.googlesource.com/c/tools/+/452055 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> gopls-CI: kokoro <[email protected]>
1 parent 36a5c6a commit c099dff

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

gopls/internal/vulncheck/command.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,14 @@ func init() {
222222
cfg.Mode = packages.NeedName | packages.NeedImports | packages.NeedTypes |
223223
packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedDeps |
224224
packages.NeedModule
225-
225+
logf := log.New(os.Stderr, "", log.Ltime).Printf
226+
logf("Loading packages...")
226227
pkgs, err := packages.Load(&cfg, patterns...)
227228
if err != nil {
229+
logf("Failed to load packages: %v", err)
228230
return err
229231
}
232+
logf("Loaded %d packages and their dependencies", len(pkgs))
230233
cli, err := client.NewClient(findGOVULNDB(&cfg), client.Options{
231234
HTTPCache: gvc.DefaultCache(),
232235
})
@@ -240,6 +243,7 @@ func init() {
240243
if err != nil {
241244
return err
242245
}
246+
logf("Found %d vulnerabilities", len(res.Vulns))
243247
if err := json.NewEncoder(os.Stdout).Encode(res); err != nil {
244248
return err
245249
}

0 commit comments

Comments
 (0)