Skip to content

Commit c07e33e

Browse files
committed
internal/lsp/source: enable type error analyzers
I had intended to enable these after gopls/v0.4.0 was released so that people who test at master can try these out. Also, mark "fillreturns" as high confidence so users can get it applied on save, much like goreturns. Change-Id: I71aa0b723b2e9b69474ceed7cb1d7da7c929d65d Reviewed-on: https://go-review.googlesource.com/c/tools/+/228724 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent e339297 commit c07e33e

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

internal/lsp/source/options.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -498,23 +498,24 @@ func (r *OptionResult) setBool(b *bool) {
498498
func typeErrorAnalyzers() map[string]Analyzer {
499499
return map[string]Analyzer{
500500
fillreturns.Analyzer.Name: {
501-
Analyzer: fillreturns.Analyzer,
502-
enabled: false,
503-
FixesError: fillreturns.FixesError,
501+
Analyzer: fillreturns.Analyzer,
502+
enabled: true,
503+
FixesError: fillreturns.FixesError,
504+
HighConfidence: true,
504505
},
505506
nonewvars.Analyzer.Name: {
506507
Analyzer: nonewvars.Analyzer,
507-
enabled: false,
508+
enabled: true,
508509
FixesError: nonewvars.FixesError,
509510
},
510511
noresultvalues.Analyzer.Name: {
511512
Analyzer: noresultvalues.Analyzer,
512-
enabled: false,
513+
enabled: true,
513514
FixesError: noresultvalues.FixesError,
514515
},
515516
undeclaredname.Analyzer.Name: {
516517
Analyzer: undeclaredname.Analyzer,
517-
enabled: false,
518+
enabled: true,
518519
FixesError: undeclaredname.FixesError,
519520
},
520521
}

0 commit comments

Comments
 (0)