Skip to content

Commit bd8508e

Browse files
committed
gopls/internal/regtest/codelens: increase the timeout on TestGCDetails
Experiment with increasing the timeout for TestGCDetails, given how its flakiness correlates with slow builders. For golang/go#44099 Change-Id: I27a8732256a77c3d9ce2a1b1f75ce5d0fbc11e67 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289690 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
1 parent 6d19fbf commit bd8508e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

gopls/internal/regtest/codelens/codelens_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"runtime"
99
"strings"
1010
"testing"
11+
"time"
1112

1213
. "golang.org/x/tools/gopls/internal/regtest"
1314

@@ -296,6 +297,8 @@ func main() {
296297
CodeLenses: map[string]bool{
297298
"gc_details": true,
298299
}},
300+
// TestGCDetails seems to suffer from poor performance on certain builders. Give it some more time to complete.
301+
Timeout(60*time.Second),
299302
).Run(t, mod, func(t *testing.T, env *Env) {
300303
env.OpenFile("main.go")
301304
env.ExecuteCodeLensCommand("main.go", source.CommandToggleDetails)

0 commit comments

Comments
 (0)