internal/lsp: stop showing workspace misconfiguration message

This is helpful for users to diagnose issues, but it annoys people who
have workspaces with both non-Go and Go projects. I'm going to spend
some more time thinking about this, particularly about which error
messages we should retry the initial workspace load for.

Updates golang/go#32394

Change-Id: I7d02b385da232914fe7342837dc3a9c4185399fd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/225237
Reviewed-by: Heschi Kreinick <[email protected]>

Author: stamblerre

internal/lsp/diagnostics.go

@@ -6,7 +6,6 @@ package lsp
 
 import (
 	"context"
-	"fmt"
 	"strings"
 	"sync"
 
@@ -62,7 +61,7 @@ func (s *Server) diagnose(ctx context.Context, snapshot source.Snapshot, alwaysA
 		return nil
 	}
 	if err != nil {
-		event.Error(ctx, "diagnose: could not generate diagnostics for go.mod file", err)
+		event.Error(ctx, "diagnose: could not generate diagnostics for go.mod file", err, tag.Directory.Of(snapshot.View().Folder))
 	}
 	// Ensure that the reports returned from mod.Diagnostics are only related to the
 	// go.mod file for the module.
@@ -85,21 +84,7 @@ func (s *Server) diagnose(ctx context.Context, snapshot source.Snapshot, alwaysA
 	if ctx.Err() != nil {
 		return nil
 	}
-	// If we encounter a genuine error when getting workspace packages,
-	// notify the user that their workspace may be misconfigured.
 	if err != nil {
-		// TODO(golang/go#37971): Remove this guard.
-		if !snapshot.View().ValidBuildConfiguration() {
-			s.showedInitialErrorMu.Lock()
-			if !s.showedInitialError {
-				err := s.client.ShowMessage(ctx, &protocol.ShowMessageParams{
-					Type:    protocol.Error,
-					Message: fmt.Sprintf("Your workspace is misconfigured: %s. Please see https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md for more information or file an issue (https://github.com/golang/go/issues/new) if you believe this is a mistake.", err.Error()),
-				})
-				s.showedInitialError = err == nil
-			}
-			s.showedInitialErrorMu.Unlock()
-		}
 		event.Error(ctx, "diagnose: no workspace packages", err, tag.Snapshot.Of(snapshot.ID()), tag.Directory.Of(snapshot.View().Folder))
 		return nil
 	}

internal/lsp/server.go

@@ -74,9 +74,6 @@ type Server struct {
 	deliveredMu sync.Mutex
 	delivered   map[span.URI]sentDiagnostics
 
-	showedInitialError   bool
-	showedInitialErrorMu sync.Mutex
-
 	// diagnosticsSema limits the concurrency of diagnostics runs, which can be expensive.
 	diagnosticsSema chan struct{}