gopls/internal/golang: don't try to inline dynamic calls

Gopls previously reported a bug when encountering a dynamic method
reference. Instead, we should just skip this reference when inlining all
calls.

Fixes golang/go#69896

Change-Id: Id6971e2a3eb79a94e76eecbfcefc44bec9040b8e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/628376
Auto-Submit: Robert Findley <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: findleyr

gopls/internal/golang/inline_all.go

@@ -152,11 +152,16 @@ func inlineAllCalls(ctx context.Context, logf func(string, ...any), snapshot *ca
 			continue
 		}
 
+		if typeutil.StaticCallee(refpkg.TypesInfo(), call) == nil {
+			continue // dynamic call
+		}
+
 		// Sanity check.
 		if obj := refpkg.TypesInfo().ObjectOf(name); obj == nil ||
 			obj.Name() != origDecl.Name.Name ||
 			obj.Pkg() == nil ||
 			obj.Pkg().Path() != string(pkg.Metadata().PkgPath) {
+
 			return nil, bug.Errorf("cannot inline: corrupted reference %v", ref)
 		}
 

gopls/internal/test/marker/testdata/codeaction/removeparam_method.txt

@@ -4,6 +4,7 @@ Specifically, check
 1. basic removal of unused parameters, when the receiver is named, locally and
    across package boundaries
 2. handling of unnamed receivers
+3. no panics related to references through interface satisfaction
 
 -- go.mod --
 module example.com/rm
@@ -37,6 +38,16 @@ func _() {
 
 func sideEffects() int
 
+type Fooer interface {
+	Foo(int)
+}
+
+// Dynamic calls aren't rewritten.
+// Previously, this would cause a bug report or crash (golang/go#69896).
+func _(f Fooer) {
+	f.Foo(1)
+}
+
 -- @basic/basic.go --
 package rm
 
@@ -66,6 +77,16 @@ func _() {
 }
 
 func sideEffects() int
+
+type Fooer interface {
+	Foo(int)
+}
+
+// Dynamic calls aren't rewritten.
+// Previously, this would cause a bug report or crash (golang/go#69896).
+func _(f Fooer) {
+	f.Foo(1)
+}
 -- missingrecv.go --
 package rm