Skip to content

Commit 9eba6e1

Browse files
committed
gopls/internal/regtest: skip known flake TestGCDetails
This test is flaking at a relatively high rate on darwin and freebsd. Skipping it is better than having a build dashboard with many known failures. Perhaps we could limit this skip to certain GOOS, but for now let's skip it entirely until we understand the problem better. For golang/go#44099 Change-Id: I58703b2db0e5768f75758080d07f9d29b8b5d661 Reviewed-on: https://go-review.googlesource.com/c/tools/+/291232 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
1 parent 9f3e226 commit 9eba6e1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

gopls/internal/regtest/codelens/codelens_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,9 @@ func Foo() {
272272
}
273273

274274
func TestGCDetails(t *testing.T) {
275+
if testing.Short() {
276+
t.Skip("Flaky test -- see golang.org/issue/44099")
277+
}
275278
testenv.NeedsGo1Point(t, 15)
276279
if runtime.GOOS == "android" {
277280
t.Skipf("the gc details code lens doesn't work on Android")

0 commit comments

Comments
 (0)