Skip to content

Commit 7a12077

Browse files
matloobfindleyr
authored andcommitted
[gopls-release-branch.0.16] all: disable tests incompatible with CL 603895
The tests disabled in this CL depend on being able to downgrade Go versions to versions earlier than Go 1.21. This behavior will change with CL 603895. Disable these tests for now and re-enable them with fixes in a later CL. For golang/go#68658 Change-Id: I13bdc03117989a128d90195ac90b2905102d293f Reviewed-on: https://go-review.googlesource.com/c/tools/+/604817 Commit-Queue: Michael Matloob <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Tim King <[email protected]> Auto-Submit: Michael Matloob <[email protected]> (cherry picked from commit 7f262d6) Reviewed-on: https://go-review.googlesource.com/c/tools/+/609416 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> TryBot-Bypass: Robert Findley <[email protected]>
1 parent 5b32599 commit 7a12077

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

go/analysis/passes/loopclosure/loopclosure_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ func Test(t *testing.T) {
2424
}
2525

2626
func TestVersions22(t *testing.T) {
27+
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
2728
testenv.NeedsGo1Point(t, 22)
2829

2930
txtar := filepath.Join(analysistest.TestData(), "src", "versions", "go22.txtar")
@@ -32,6 +33,7 @@ func TestVersions22(t *testing.T) {
3233
}
3334

3435
func TestVersions18(t *testing.T) {
36+
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
3537
txtar := filepath.Join(analysistest.TestData(), "src", "versions", "go18.txtar")
3638
dir := testfiles.ExtractTxtarFileToTmp(t, txtar)
3739
analysistest.Run(t, dir, loopclosure.Analyzer, "golang.org/fake/versions")

go/analysis/passes/stdversion/stdversion_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
)
1616

1717
func Test(t *testing.T) {
18+
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
1819
// The test relies on go1.21 std symbols, but the analyzer
1920
// itself requires the go1.22 implementation of versions.FileVersions.
2021
testenv.NeedsGo1Point(t, 22)

go/ssa/interp/interp_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ var testdataTests = []string{
117117
"deepequal.go",
118118
"defer.go",
119119
"fieldprom.go",
120-
"forvarlifetime_old.go",
120+
// "forvarlifetime_old.go", Disabled for golang.org/cl/603895. Fix and re-enable.
121121
"ifaceconv.go",
122122
"ifaceprom.go",
123123
"initorder.go",
@@ -129,7 +129,7 @@ var testdataTests = []string{
129129
"slice2arrayptr.go",
130130
"static.go",
131131
"width32.go",
132-
"rangevarlifetime_old.go",
132+
// "rangevarlifetime_old.go", Disabled for golang.org/cl/603895. Fix and re-enable.
133133
"fixedbugs/issue52342.go",
134134
"fixedbugs/issue55115.go",
135135
"fixedbugs/issue52835.go",

internal/testfiles/testfiles_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
)
1818

1919
func TestTestDir(t *testing.T) {
20+
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
2021
testenv.NeedsGo1Point(t, 22)
2122

2223
// TODO(taking): Expose a helper for this pattern?

0 commit comments

Comments
 (0)