Skip to content

Commit 618670d

Browse files
adonovangopherbot
authored andcommitted
gopls/internal/test/integration/misc: reenable staticcheck test
This test reenables the staticcheck test, which now passes with gotypesalias={,0,1}. (Staticcheck may yet need work, but that isn't evident to our tests.) Updates golang/go#64581 Change-Id: I1c8acca2c6b7d16e551a5c8a68be564254713d0d Reviewed-on: https://go-review.googlesource.com/c/tools/+/579756 Auto-Submit: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent 2debfbe commit 618670d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

gopls/internal/test/integration/misc/staticcheck_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ import (
1515
func TestStaticcheckGenerics(t *testing.T) {
1616
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+
1717

18-
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
19-
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")
20-
2118
const files = `
2219
-- go.mod --
2320
module mod.com
@@ -83,9 +80,6 @@ var FooErr error = errors.New("foo")
8380
func TestStaticcheckRelatedInfo(t *testing.T) {
8481
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+
8582

86-
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
87-
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")
88-
8983
const files = `
9084
-- go.mod --
9185
module mod.test

0 commit comments

Comments
 (0)