internal/lsp/cache: use snapshot ID and view folder in ModTidyHandle key

Just to be safe, the snapshot ID and view's folder should be enough to
uniquely identify the ModTidyHandle.

Change-Id: Ie3a0dc64bf16bcc8e4eb75af107481c07de81967
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217657
Run-TryBot: Rebecca Stambler <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>

Author: stamblerre

internal/lsp/cache/mod_tidy.go

@@ -29,8 +29,9 @@ const ModTidyError = "go mod tidy"
 const SyntaxError = "syntax"
 
 type parseModKey struct {
-	snapshot source.Snapshot
-	cfg      string
+	view       string
+	snapshotID uint64
+	cfg        string
 }
 
 type modTidyHandle struct {
@@ -96,8 +97,9 @@ func (s *snapshot) ModTidyHandle(ctx context.Context, realfh source.FileHandle)
 	folder := s.View().Folder().Filename()
 
 	key := parseModKey{
-		snapshot: s,
-		cfg:      hashConfig(cfg),
+		view:       folder,
+		snapshotID: s.ID(),
+		cfg:        hashConfig(cfg),
 	}
 	h := s.view.session.cache.store.Bind(key, func(ctx context.Context) interface{} {
 		data := &modTidyData{}