Skip to content

Commit 3e82a5b

Browse files
Bryan C. Millsgopherbot
Bryan C. Mills
authored andcommitted
internal/gcimporter: avoid test assumptions about internal packages in other repos
TestImportedTypes was assuming that go/internal/gcimporter declares a FindPkg function with a particular signature. However, since go/internal/gcimporter is internal, it is not subject to Go 1 compatibility and its API is subject to change. I intend to change it in CL 507360. For golang/go#61064. Change-Id: I994f5b967ce9c57d07ce1fe8b6ce900176848efa Reviewed-on: https://go-review.googlesource.com/c/tools/+/511758 Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Alan Donovan <[email protected]> Run-TryBot: Bryan Mills <[email protected]>
1 parent 7ba5690 commit 3e82a5b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

internal/gcimporter/gcimporter_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,6 @@ var importedObjectTests = []struct {
395395
{"math.Pi", "const Pi untyped float"},
396396
{"math.Sin", "func Sin(x float64) float64"},
397397
{"go/ast.NotNilFilter", "func NotNilFilter(_ string, v reflect.Value) bool"},
398-
{"go/internal/gcimporter.FindPkg", "func FindPkg(path string, srcDir string) (filename string, id string)"},
399398

400399
// interfaces
401400
{"context.Context", "type Context interface{Deadline() (deadline time.Time, ok bool); Done() <-chan struct{}; Err() error; Value(key any) any}"},

0 commit comments

Comments
 (0)