internal/lsp: fix tiny bug in getting files by basename

stamblerre · stamblerre · commit 2898d834dca3 · 2019-03-28T02:26:11.000Z
This change fixes gopls on Windows. Fixes golang/go#30967 Change-Id: Iba5eb6932a4acd6a574ad6970faf7c133ecb7d32 Reviewed-on: https://go-review.googlesource.com/c/tools/+/169703 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go
@@ -234,7 +234,7 @@ func (v *View) findFile(uri span.URI) *File {
 	basename := basename(fname)
 	if candidates := v.filesByBase[basename]; candidates != nil {
 		pathStat, err := os.Stat(fname)
-		if err == nil {
+		if err != nil {
 			return nil
 		}
 		for _, c := range candidates {

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ func (v View) findFile(uri span.URI) File {`
`234`	`234`	`basename := basename(fname)`
`235`	`235`	`if candidates := v.filesByBase[basename]; candidates != nil {`
`236`	`236`	`pathStat, err := os.Stat(fname)`
`237`		`- if err == nil {`
	`237`	`+ if err != nil {`
`238`	`238`	`return nil`
`239`	`239`	`}`
`240`	`240`	`for _, c := range candidates {`