Skip to content

Commit 198986d

Browse files
timothy-kinggopherbot
authored andcommitted
go/ssa: go/ssa: disable TestTypeparamTest on wasm
watchflakes reported additional test cases for TestTypeparamTest on wasm. Skipping the test when on wasm. Fixes golang/go#69410 Fixes golang/go#69409 Change-Id: Icfe5da007bf7411e9875313bc1b190751f1c1a15 Reviewed-on: https://go-review.googlesource.com/c/tools/+/612855 Commit-Queue: Tim King <[email protected]> Reviewed-by: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Tim King <[email protected]>
1 parent 3e49191 commit 198986d

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

go/ssa/builder_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,13 @@ func TestTypeparamTest(t *testing.T) {
777777
// Tests use a fake goroot to stub out standard libraries with declarations in
778778
// testdata/src. Decreases runtime from ~80s to ~1s.
779779

780+
if runtime.GOARCH == "wasm" {
781+
// Consistent flakes on wasm (#64726, #69409, #69410).
782+
// Needs more investigation, but more likely a wasm issue
783+
// Disabling for now.
784+
t.Skip("Consistent flakes on wasm (e.g. https://go.dev/issues/64726)")
785+
}
786+
780787
dir := filepath.Join(build.Default.GOROOT, "test", "typeparam")
781788

782789
// Collect all of the .go files in
@@ -786,9 +793,6 @@ func TestTypeparamTest(t *testing.T) {
786793
}
787794

788795
for _, entry := range list {
789-
if entry.Name() == "chans.go" && runtime.GOARCH == "wasm" {
790-
continue // https://go.dev/issues/64726 runtime: found bad pointer
791-
}
792796
if entry.IsDir() || !strings.HasSuffix(entry.Name(), ".go") {
793797
continue // Consider standalone go files.
794798
}

go/ssa/interp/interp_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,11 @@ func TestGorootTest(t *testing.T) {
307307
// in $GOROOT/test/typeparam/*.go.
308308

309309
func TestTypeparamTest(t *testing.T) {
310+
if runtime.GOARCH == "wasm" {
311+
// See ssa/TestTypeparamTest.
312+
t.Skip("Consistent flakes on wasm (e.g. https://go.dev/issues/64726)")
313+
}
314+
310315
goroot := makeGoroot(t)
311316

312317
// Skip known failures for the given reason.

0 commit comments

Comments
 (0)