gopls/internal/regtest: re-enable the gc_details regtest for -short

findleyr · findleyr · commit 0deaffd2009f · 2021-03-30T20:26:08.000Z
My hope is that CL 304169 resolved this flake, but we'll have to see. For golang/go#44099 Change-Id: Iac82dc24167daacd0361eac1a5567048a7ecf11c Reviewed-on: https://go-review.googlesource.com/c/tools/+/305409 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
diff --git a/gopls/internal/regtest/codelens/codelens_test.go b/gopls/internal/regtest/codelens/codelens_test.go
@@ -275,9 +275,6 @@ func Foo() {
 }
 
 func TestGCDetails(t *testing.T) {
-	if testing.Short() {
-		t.Skip("Flaky test -- see golang.org/issue/44099")
-	}
 	testenv.NeedsGo1Point(t, 15)
 	if runtime.GOOS == "android" {
 		t.Skipf("the gc details code lens doesn't work on Android")

Original file line number	Diff line number	Diff line change
`@@ -275,9 +275,6 @@ func Foo() {`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`func TestGCDetails(t *testing.T) {`
`278`		`- if testing.Short() {`
`279`		`- t.Skip("Flaky test -- see golang.org/issue/44099")`
`280`		`- }`
`281`	`278`	`testenv.NeedsGo1Point(t, 15)`
`282`	`279`	`if runtime.GOOS == "android" {`
`283`	`280`	`t.Skipf("the gc details code lens doesn't work on Android")`