Skip to content

Commit f5ab9c3

Browse files
committed
config: add crash counters
Add the crash related counters described in golang/go#65696. Also, regenerate the config since we'll want to see these counters ASAP. Fixes golang/go#65696 Change-Id: Ibcd861cd25fafe6c1a71ceda74429a1669b222e0 Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/564619 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
1 parent 3d451a4 commit f5ab9c3

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed

config/config.json

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,13 +538,26 @@
538538
{
539539
"Name": "gopls/goversion:{1.16,1.17,1.18,1.19,1.20,1.21,1.22,1.23,1.24,1.25,1.26,1.27,1.28,1.29,1.30}",
540540
"Rate": 1
541+
},
542+
{
543+
"Name": "crash/malformed",
544+
"Rate": 1
545+
},
546+
{
547+
"Name": "crash/no-running-goroutine",
548+
"Rate": 1
541549
}
542550
],
543551
"Stacks": [
544552
{
545553
"Name": "gopls/bug",
546554
"Rate": 1,
547555
"Depth": 16
556+
},
557+
{
558+
"Name": "crash/crash",
559+
"Rate": 1,
560+
"Depth": 16
548561
}
549562
]
550563
}

internal/configgen/config.txt

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,28 @@ issue: https://go.dev/issue/62249
2626
program: golang.org/x/tools/gopls
2727
depth: 16
2828
version: v0.13.0
29+
---
30+
counter: crash/crash
31+
title: Unexpected Go crashes
32+
description: stacks of goroutines running when the Go program crashed
33+
type: stack
34+
issue: https://go.dev/issue/65696
35+
program: golang.org/x/tools/gopls
36+
depth: 16
37+
version: v0.15.0
38+
---
39+
counter: crash/malformed
40+
title: Failure to parse runtime crash output
41+
description: count of runtime crash messages that failed to parse
42+
type: partition
43+
issue: https://go.dev/issue/65696
44+
program: golang.org/x/tools/gopls
45+
version: v0.15.0
46+
---
47+
counter: crash/no-running-goroutine
48+
title: Failure to identify any running goroutine in the crash output
49+
description: count of runtime crash messages that don't have a running goroutine (e.g. deadlock)
50+
type: partition
51+
issue: https://go.dev/issue/65696
52+
program: golang.org/x/tools/gopls
53+
version: v0.15.0

0 commit comments

Comments
 (0)