Skip to content

Why was types moved to ptypes #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awalterschulze opened this issue Aug 28, 2016 · 3 comments
Closed

Why was types moved to ptypes #223

awalterschulze opened this issue Aug 28, 2016 · 3 comments
Labels

Comments

@awalterschulze
Copy link

1270911
I am busy merging well known types into a fork of golang/protobuf
I would just like to know, since I'll probably prefer to keep the well known types in the types folder instead of the ptypes folder.

@zombiezen
Copy link
Contributor

At the moment, I'm not sure (cc @okdave for comment). I like ptypes as a name since it aligns with advice around package names. In some ways, I think this is very similar to #218 (about to respond there more fully).

@okdave
Copy link
Contributor

okdave commented Aug 30, 2016

I think this was a discussion between @dsymonds and r; I wasn't involved in the reasoning (the main reason I can think of is that types might be confused with Go types).

@awalterschulze
Copy link
Author

Thanks good to know.

@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants