Skip to content

Commit 4852103

Browse files
author
Bryan C. Mills
committed
netutil: skip TestLimitListener on plan9
This may be a platform bug, but nobody has investigated it since the issue was filed in 2017. Skip it to reduce noise from flakes. For golang/go#22926 Change-Id: I8f310a539992c4552abb50fea3c7adc2149818ef Reviewed-on: https://go-review.googlesource.com/c/net/+/369054 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: David du Colombier <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 0a0e4e1 commit 4852103

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

netutil/listen_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"io/ioutil"
1212
"net"
1313
"net/http"
14+
"runtime"
1415
"sync"
1516
"sync/atomic"
1617
"testing"
@@ -21,6 +22,10 @@ const defaultMaxOpenFiles = 256
2122
const timeout = 5 * time.Second
2223

2324
func TestLimitListener(t *testing.T) {
25+
if runtime.GOOS == "plan9" {
26+
t.Skipf("skipping test known to be flaky on plan9 (https://golang.org/issue/22926)")
27+
}
28+
2429
const max = 5
2530
attempts := (maxOpenFiles() - max) / 2
2631
if attempts > 256 { // maximum length of accept queue is 128 by default

0 commit comments

Comments
 (0)