Skip to content

Commit 4d494e8

Browse files
committed
make this branch ready for a PR
1 parent a921f27 commit 4d494e8

File tree

1 file changed

+20
-28
lines changed

1 file changed

+20
-28
lines changed

cmd/gobind/gen.go

Lines changed: 20 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414
"io/ioutil"
1515
"os"
1616
"path/filepath"
17-
"runtime"
1817
"strings"
1918
"unicode"
2019
"unicode/utf8"
@@ -47,8 +46,6 @@ func genPkg(lang string, p *types.Package, astFiles []*ast.File, allPkg []*types
4746
Pkg: conf.Pkg,
4847
Files: astFiles,
4948
}
50-
_, thisfile, _, _ := runtime.Caller(0)
51-
gomobiledir := thisfile[:strings.Index(thisfile, "/mobile/")+len("/mobile/")]
5249
switch lang {
5350
case "java":
5451
g := &bind.JavaGen{
@@ -83,13 +80,11 @@ func genPkg(lang string, p *types.Package, astFiles []*ast.File, allPkg []*types
8380
closer()
8481
// Generate support files along with the universe package
8582
if p == nil {
86-
// dir, err := packageDir("golang.org/x/mobile/bind")
87-
// if err != nil {
88-
// errorf(`"golang.org/x/mobile/bind" is not found; run go get golang.org/x/mobile/bind: %v`, err)
89-
// return
90-
// }
91-
dir := gomobiledir + "/bind"
92-
var err error
83+
dir, err := packageDir("golang.org/x/mobile/bind")
84+
if err != nil {
85+
errorf(`"golang.org/x/mobile/bind" is not found; run go get golang.org/x/mobile/bind: %v`, err)
86+
return
87+
}
9388
repo := filepath.Clean(filepath.Join(dir, "..")) // golang.org/x/mobile directory.
9489
for _, javaFile := range []string{"Seq.java", "NativeUtils.java"} {
9590
src := filepath.Join(repo, "bind/java/"+javaFile)
@@ -110,12 +105,11 @@ func genPkg(lang string, p *types.Package, astFiles []*ast.File, allPkg []*types
110105
errorf("unable to import bind/java: %v", err)
111106
return
112107
}
113-
// javaDir, err := packageDir("golang.org/x/mobile/bind/java")
114-
// if err != nil {
115-
// errorf("unable to import bind/java: %v", err)
116-
// return
117-
// }
118-
javaDir := gomobiledir + "/bind/java"
108+
javaDir, err := packageDir("golang.org/x/mobile/bind/java")
109+
if err != nil {
110+
errorf("unable to import bind/java: %v", err)
111+
return
112+
}
119113
copyFile(filepath.Join("src", "gobind", "seq_java.c"), filepath.Join(javaDir, "seq_android.c.support"))
120114
copyFile(filepath.Join("src", "gobind", "seq_java.go"), filepath.Join(javaDir, "seq_android.go.support"))
121115
copyFile(filepath.Join("src", "gobind", "seq_java.h"), filepath.Join(javaDir, "seq_android.h"))
@@ -133,12 +127,11 @@ func genPkg(lang string, p *types.Package, astFiles []*ast.File, allPkg []*types
133127
genPkgH(w, "seq")
134128
io.Copy(w, &buf)
135129
closer()
136-
// dir, err := packageDir("golang.org/x/mobile/bind")
137-
// if err != nil {
138-
// errorf("unable to import bind: %v", err)
139-
// return
140-
// }
141-
dir := gomobiledir + "/bind"
130+
dir, err := packageDir("golang.org/x/mobile/bind")
131+
if err != nil {
132+
errorf("unable to import bind: %v", err)
133+
return
134+
}
142135
copyFile(filepath.Join("src", "gobind", "seq.go"), filepath.Join(dir, "seq.go.support"))
143136
case "objc":
144137
g := &bind.ObjcGen{
@@ -163,12 +156,11 @@ func genPkg(lang string, p *types.Package, astFiles []*ast.File, allPkg []*types
163156
closer()
164157
if p == nil {
165158
// Copy support files
166-
// dir, err := packageDir("golang.org/x/mobile/bind/objc")
167-
// if err != nil {
168-
// errorf("unable to import bind/objc: %v", err)
169-
// return
170-
// }
171-
dir := gomobiledir + "/bind/objc"
159+
dir, err := packageDir("golang.org/x/mobile/bind/objc")
160+
if err != nil {
161+
errorf("unable to import bind/objc: %v", err)
162+
return
163+
}
172164
copyFile(filepath.Join("src", "gobind", "seq_darwin.m"), filepath.Join(dir, "seq_darwin.m.support"))
173165
copyFile(filepath.Join("src", "gobind", "seq_darwin.go"), filepath.Join(dir, "seq_darwin.go.support"))
174166
copyFile(filepath.Join("src", "gobind", "ref.h"), filepath.Join(dir, "ref.h"))

0 commit comments

Comments
 (0)