Skip to content

net: allow TCP only DNS requests in the pure Go resolver on unix #29367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jfbus
Copy link
Contributor

@jfbus jfbus commented Dec 20, 2018

There is a DNS resolution bug in Kubernetes (UDP response packets get dropped by conntrack, causing timeouts in DNS queries).

This enables configuration of the pure Go resolver to use TCP, either using the GODEBUG env var (GODEBUG=netdns=go+tcp) or using the Resolver.PreferTCP flag.

Fixes #29358

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 20, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: cd77ba3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

This would need test and docs.

But you should start with a proposal bug to get approval on such an API change before we discuss code.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jean-François Bustarret:

Patch Set 1:

Patch Set 1:

This would need test and docs.

Will be added.

But you should start with a proposal bug to get approval on such an API change before we discuss code.

Is the github issue enough ? #29358


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Patch Set 1:

Patch Set 1:

This would need test and docs.

Will be added.

But you should start with a proposal bug to get approval on such an API change before we discuss code.

Is the github issue enough ? #29358

Yup, thanks. I converted it into a proposal.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 541f2d0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/155378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jean-François Bustarret:

Patch Set 2:

Unit test & godoc added.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jean-François Bustarret:

Patch Set 2:

An alternate CL with a smaller impact is here : https://go-review.googlesource.com/c/go/+/156366


Please don’t reply on this GitHub thread. Visit golang.org/cl/155378.
After addressing review feedback, remember to publish your drafts!

@jfbus
Copy link
Contributor Author

jfbus commented Jan 10, 2019

Replaced by #29594

@jfbus jfbus closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: add configuration knob to force TCP-only DNS requests in the pure Go resolver on unix
3 participants