-
Notifications
You must be signed in to change notification settings - Fork 18.3k
net: allow TCP only DNS requests in the pure Go resolver on unix #29367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: cd77ba3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/155378 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
Message from Brad Fitzpatrick: Patch Set 1: This would need test and docs. But you should start with a proposal bug to get approval on such an API change before we discuss code. Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
Message from Jean-François Bustarret: Patch Set 1:
Will be added.
Is the github issue enough ? #29358 Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
Message from Brad Fitzpatrick: Patch Set 1:
Yup, thanks. I converted it into a proposal. Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
This PR (HEAD: 541f2d0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/155378 to see it. Tip: You can toggle comments from me using the |
Message from Jean-François Bustarret: Patch Set 2: Unit test & godoc added. Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
Message from Jean-François Bustarret: Patch Set 2: An alternate CL with a smaller impact is here : https://go-review.googlesource.com/c/go/+/156366 Please don’t reply on this GitHub thread. Visit golang.org/cl/155378. |
Replaced by #29594 |
There is a DNS resolution bug in Kubernetes (UDP response packets get dropped by conntrack, causing timeouts in DNS queries).
This enables configuration of the pure Go resolver to use TCP, either using the GODEBUG env var (GODEBUG=netdns=go+tcp) or using the Resolver.PreferTCP flag.
Fixes #29358