Skip to content

x/tools/gopls/internal/test/marker: tests are timing out on freebsd #67674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
findleyr opened this issue May 28, 2024 · 2 comments
Closed

x/tools/gopls/internal/test/marker: tests are timing out on freebsd #67674

findleyr opened this issue May 28, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. OS-FreeBSD Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Member

It looks like the freebsd builders recently started timing out.

image

However, the CL where this started is https://go.dev/cl/586878, which did not change any code linked by that test.
Therefore, this may be a builder issue, or perhaps a change in std triggered a change in performance.

(the marker tests are heavily affected by I/O. It looks like sometimes they finish in ~2m, but then timing spikes to 10m).

CC @zpavlinovic, who noticed this.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 28, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 28, 2024
@findleyr
Copy link
Member Author

findleyr commented May 28, 2024

I'll note that the LUCI freebsd builders are also broken, but are OK with Go 1.22 (dashboard). Also, the main repo freebsd builders are very unhappy (though perhaps just with TestVerifyCertificates).

Therefore, this points to some regression in the main repo.

CC @golang/release @golang/freebsd

@findleyr findleyr modified the milestones: Unreleased, Go1.23 May 28, 2024
@findleyr
Copy link
Member Author

Looks like this was fixed along with #67585.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. OS-FreeBSD Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants