x/tools/cmd/gonew test failure "unexpected file out/upload.token"

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "Test"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: Test (0.67s)
    --- FAIL: Test/quote.txt (0.67s)
        main_test.go:138: unexpected file out/upload.token:

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "Test"

2024-03-04 22:41 netbsd-arm-bsiegert tools@7656c4c6 go@5dcc04ae x/tools/gopls/internal/cmd.Test (log)

--- FAIL: Test (0.67s)
    --- FAIL: Test/quote.txt (0.67s)
        main_test.go:138: unexpected file out/upload.token:

— watchflakes

[adonovan]

The first test failure here is related to the new upload.token file created by x/telemetry. Assigning to @matloob to investigate.

[adonovan]

The second failure (in x/tools/gopls/internal/cmd) appears to have a similar cause.

[matloob]

These tests are seeing the upload.token file in places where they don't expect it. This seems to be happening because HOME and XDG_CONFIG_HOME aren't set [on a unix platform], so telemetry.LocalDir isn't set, but we're still creating the upload.token file at filepath.Join(telemetry.LocalDir, "upload.token"). We should explicitly check for the case where telemetry.LocalDir isn't set and skip uploading completely in that case. (there are no counters to upload anyways in that case).

[gopherbot]

Change https://go.dev/cl/569217 mentions this issue: telemetry: in Start skip uploading in certain cases