Skip to content

net/http: TestOmitHTTP2 failures #62246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 23, 2023 · 3 comments
Closed

net/http: TestOmitHTTP2 failures #62246

gopherbot opened this issue Aug 23, 2023 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Aug 23, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "net/http" && test == "TestOmitHTTP2" && `Expected proxy copy error`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestOmitHTTP2 (6.85s)
    http_test.go:93: go test -short failed: exit status 1, --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
            --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
                transport_test.go:6824: Backend address: 127.0.0.1:34785
                transport_test.go:6842: Proxy address: 127.0.0.1:42763
                transport_test.go:6838: Expected proxy copy error
        FAIL
        FAIL	net/http	2.226s
        FAIL

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 23, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestOmitHTTP2"
2023-08-23 05:58 linux-amd64-longtest-race go@e68c0272 net/http.TestOmitHTTP2 (log) 
--- FAIL: TestOmitHTTP2 (6.85s)
    http_test.go:93: go test -short failed: exit status 1, --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
            --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
                transport_test.go:6824: Backend address: 127.0.0.1:34785
                transport_test.go:6842: Proxy address: 127.0.0.1:42763
                transport_test.go:6838: Expected proxy copy error
        FAIL
        FAIL	net/http	2.226s
        FAIL

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Aug 23, 2023

Duplicate of #62224

@bcmills bcmills marked this as a duplicate of #62224 Aug 23, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 23, 2023

I've updated the watchflakes pattern for that issue, and will remove this one from the Test Flakes project.

@bcmills bcmills removed this from Test Flakes Aug 23, 2023
@golang golang locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot