Skip to content

Running benchmarks briefly.: unrecognized failures #60375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue May 23, 2023 · 7 comments
Closed

Running benchmarks briefly.: unrecognized failures #60375

gopherbot opened this issue May 23, 2023 · 7 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

gopherbot commented May 23, 2023

#!watchflakes
default <- repo == "go" && section == "Running benchmarks briefly." && test == ""

Issue created automatically to collect these failures.

Example (log):

Test {"go_test_bench:runtime" "runtime:racebench"} ran over 20m0s limit (20m0.001065357s); saw output:


XXXBANNERXXX:Running benchmarks briefly.
goos: freebsd
goarch: amd64
pkg: runtime
cpu: Intel(R) Xeon(R) CPU @ 2.20GHz
BenchmarkCallers/cached-4                     	   70389	      1722 ns/op
BenchmarkCallers/inlined-4                    	   52812	      2267 ns/op
...
BenchmarkConvT2Ezero/smallint/64-4            	 5556379	        21.52 ns/op
BenchmarkConvT2Ezero/largeint/16-4            	 1687078	        63.02 ns/op
BenchmarkConvT2Ezero/largeint/32-4            	 1952485	        63.81 ns/op
BenchmarkConvT2Ezero/largeint/64-4            	 1639464	        75.60 ns/op
BenchmarkMalloc8-4                            	 1628454	        73.00 ns/op
BenchmarkMalloc16-4                           	 1480303	        78.20 ns/op
BenchmarkMallocTypeInfo8-4                    	 1539338	        81.77 ns/op
BenchmarkMallocTypeInfo16-4                   	 1285708	        92.32 ns/op
BenchmarkMallocLargeStruct-4                  	  227884	       635.4 ns/op
BenchmarkGoroutineSelect-4                    	

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "go" && section == "Running benchmarks briefly." && test == ""
2023-05-23 18:15 freebsd-amd64-race go@b0f15b4a (log)
Test {"go_test_bench:runtime" "runtime:racebench"} ran over 20m0s limit (20m0.001065357s); saw output:


XXXBANNERXXX:Running benchmarks briefly.
goos: freebsd
goarch: amd64
pkg: runtime
cpu: Intel(R) Xeon(R) CPU @ 2.20GHz
BenchmarkCallers/cached-4                     	   70389	      1722 ns/op
BenchmarkCallers/inlined-4                    	   52812	      2267 ns/op
...
BenchmarkConvT2Ezero/smallint/64-4            	 5556379	        21.52 ns/op
BenchmarkConvT2Ezero/largeint/16-4            	 1687078	        63.02 ns/op
BenchmarkConvT2Ezero/largeint/32-4            	 1952485	        63.81 ns/op
BenchmarkConvT2Ezero/largeint/64-4            	 1639464	        75.60 ns/op
BenchmarkMalloc8-4                            	 1628454	        73.00 ns/op
BenchmarkMalloc16-4                           	 1480303	        78.20 ns/op
BenchmarkMallocTypeInfo8-4                    	 1539338	        81.77 ns/op
BenchmarkMallocTypeInfo16-4                   	 1285708	        92.32 ns/op
BenchmarkMallocLargeStruct-4                  	  227884	       635.4 ns/op
BenchmarkGoroutineSelect-4                    	

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "go" && section == "Running benchmarks briefly." && test == ""
2023-04-11 20:54 darwin-amd64-race go@171c7940 (log)
Test "go_test_bench:runtime" ran over 20m0s limit (20m0.000544852s); saw output:


XXXBANNERXXX:Running benchmarks briefly.
goos: darwin
goarch: amd64
pkg: runtime
BenchmarkCallers/cached-4                 	   86800	      1835 ns/op
BenchmarkCallers/inlined-4                	   57732	      2355 ns/op
BenchmarkCallers/no-cache-4               	   13660	      8647 ns/op
...
BenchmarkConvT2Ezero/smallint/32-4        	 3399672	        31.08 ns/op
BenchmarkConvT2Ezero/smallint/64-4        	 3727742	        51.82 ns/op
BenchmarkConvT2Ezero/largeint/16-4        	 1000000	       132.0 ns/op
BenchmarkConvT2Ezero/largeint/32-4        	 1000000	       145.0 ns/op
BenchmarkConvT2Ezero/largeint/64-4        	 1000000	       138.4 ns/op
BenchmarkMalloc8-4                        	  896478	       162.4 ns/op
BenchmarkMalloc16-4                       	 1000000	       166.2 ns/op
BenchmarkMallocTypeInfo8-4                	 1000000	       181.4 ns/op
BenchmarkMallocTypeInfo16-4               	  634833	       310.8 ns/op
BenchmarkMallocLargeStruct-4              	   49915	      2881 ns/op

watchflakes

@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 23, 2023
@bcmills
Copy link
Contributor

bcmills commented May 23, 2023

Possibly a dup of #60050 (attn @mknyszek)?

@mknyszek
Copy link
Contributor

Yeah, I think it might be a dup. If the timer ends up having its "when" field corrupted I think the benchmark might try to run for more than 1 second (potentially many seconds).

@mknyszek
Copy link
Contributor

Closing as a duplicate of #60050.

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "go" && section == "Running benchmarks briefly." && test == ""
2023-05-30 22:14 linux-amd64-longtest-race go@4497b123 runtime (log)
goos: linux
goarch: amd64
pkg: runtime
cpu: Intel(R) Xeon(R) CPU @ 2.20GHz
BenchmarkCallers/cached-4                     	   70426	      1702 ns/op
BenchmarkCallers/inlined-4                    	   52648	      2261 ns/op
BenchmarkCallers/no-cache-4                   	   10000	     10077 ns/op
BenchmarkFPCallers/cached-4                   	 2868400	        41.77 ns/op
BenchmarkMakeChan/Byte-4                      	 1177291	       104.5 ns/op
BenchmarkMakeChan/Int-4                       	  858823	       124.3 ns/op
...
fatal error: found pointer to free object

goroutine 3 [running]:
runtime.throw({0xa738a9?, 0xc0000120f0?})
	/workdir/go/src/runtime/panic.go:1077 +0x5c fp=0xc000078d88 sp=0xc000078d58 pc=0x4735bc
runtime.(*mspan).reportZombies(0x7faa148c91d8)
	/workdir/go/src/runtime/mgcsweep.go:861 +0x2e5 fp=0xc000078e08 sp=0xc000078d88 pc=0x461885
runtime.(*sweepLocked).sweep(0xde2680?, 0x0)
	/workdir/go/src/runtime/mgcsweep.go:644 +0xbb4 fp=0xc000078f28 sp=0xc000078e08 pc=0x461174
runtime.sweepone()
...
runtime.goexit()
	/workdir/go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc000078fe8 sp=0xc000078fe0 pc=0x4b5201
created by runtime.gcenable in goroutine 1
	/workdir/go/src/runtime/mgc.go:200 +0x66

goroutine 4580 [running]:
	goroutine running on other thread; stack unavailable
created by testing.(*B).doBench in goroutine 1
	/workdir/go/src/testing/benchmark.go:284 +0xa5
exit status 2

watchflakes

@gopherbot gopherbot reopened this May 31, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Go Compiler / Runtime May 31, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "go" && section == "Running benchmarks briefly." && test == ""
2023-05-05 19:20 linux-amd64-race go@f90bb8a3 runtime (log)
goos: linux
goarch: amd64
pkg: runtime
cpu: Intel(R) Xeon(R) CPU @ 2.20GHz
BenchmarkCallers/cached-4                 	   69576	      1721 ns/op
BenchmarkCallers/inlined-4                	   52701	      2280 ns/op
BenchmarkCallers/no-cache-4               	   10000	     10032 ns/op
BenchmarkFPCallers/cached-4               	 2843337	        42.79 ns/op
BenchmarkMakeChan/Byte-4                  	 1186437	        92.75 ns/op
BenchmarkMakeChan/Int-4                   	  938323	       132.2 ns/op
...
runtime.goexit0(0xc000505a00)
	/workdir/go/src/runtime/proc.go:3703 +0x266 fp=0x7f531fffee68 sp=0x7f531fffee28 pc=0x47b606
runtime.mcall()
	/workdir/go/src/runtime/asm_amd64.s:458 +0x4e fp=0x7f531fffee80 sp=0x7f531fffee68 pc=0x4af98e

goroutine 4549 [running]:
	goroutine running on other thread; stack unavailable
created by testing.(*B).doBench in goroutine 1
	/workdir/go/src/testing/benchmark.go:284 +0xa5
exit status 2

watchflakes

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jun 30, 2023
@golang golang locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Archived in project
Development

No branches or pull requests

3 participants