Skip to content

x/tools/gopls/internal/regtest/misc: TestRenamePackage_InternalPackage failures #59765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 21, 2023 · 9 comments
Closed

x/tools/gopls/internal/regtest/misc: TestRenamePackage_InternalPackage failures #59765

gopherbot opened this issue Apr 21, 2023 · 9 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Apr 21, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_InternalPackage" && `panic: test timed out`

Issue created automatically to collect these failures.

Example (log):

serve.go:434: debug server listening at http://localhost:54017
serve.go:434: debug server listening at http://localhost:54018
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_InternalPackage (9m8s)
	TestRenamePackage_InternalPackage/default (9m8s)

testing.(*T).Run(0x140058b5860, {0x1012d9ac1?, 0x1012f6e24?}, 0x14001f0d310)
	/tmp/buildlet/go/src/testing/testing.go:1649 +0x350
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x1400049d180, 0x140058b5860, {0x10134e399, 0x121}, 0x101771888, {0x0, 0x0, 0x6441b4a9?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x400
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage(0x140068a1040?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:897 +0x64
testing.tRunner(0x140058b5860, 0x101771890)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 21, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_InternalPackage"
2023-04-20 21:20 darwin-arm64-12 tools@6deeacb5 go@608f204a x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage (log) 
serve.go:434: debug server listening at http://localhost:54017
serve.go:434: debug server listening at http://localhost:54018
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_InternalPackage (9m8s)
	TestRenamePackage_InternalPackage/default (9m8s)

testing.(*T).Run(0x140058b5860, {0x1012d9ac1?, 0x1012f6e24?}, 0x14001f0d310)
	/tmp/buildlet/go/src/testing/testing.go:1649 +0x350
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x1400049d180, 0x140058b5860, {0x10134e399, 0x121}, 0x101771888, {0x0, 0x0, 0x6441b4a9?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x400
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage(0x140068a1040?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:897 +0x64
testing.tRunner(0x140058b5860, 0x101771890)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 21, 2023
@findleyr
Copy link
Member

This is a dupe of #54461, and predates @bcmills' change to set WaitDelay.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
@gopherbot gopherbot reopened this May 16, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_InternalPackage"
2023-05-16 16:48 darwin-arm64-12 tools@19d700c6 go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage (log) 
serve.go:434: debug server listening at http://localhost:57165
serve.go:434: debug server listening at http://localhost:57166
panic: test timed out after 10m0s

testing.(*T).Run(0x14007a35d40, {0x102969d5b?, 0x10298708c?}, 0x14003026910)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x314
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x14000507040, 0x14007a35d40, {0x1029dd9bc, 0x121}, 0x102e15030, {0x0, 0x0, 0x6463b4ff?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x46c
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage(0x1400753ab60?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:897 +0x68
testing.tRunner(0x14007a35d40, 0x102e15038)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 16, 2023

That one is on release-branch.go1.19, which means it does not benefit from the WaitDelay added in https://go.dev/cl/484743.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_InternalPackage"
2023-05-10 18:30 netbsd-386-9_3 tools@787e7207 go@484330d0 x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage (log) 
serve.go:434: debug server listening at http://localhost:65426
serve.go:434: debug server listening at http://localhost:65425
panic: test timed out after 10m0s

testing.(*T).Run(0x9fc0000, {0x8b27b44, 0x7}, 0xb0e6a20)
	/tmp/workdir/go/src/testing/testing.go:1494 +0x38d
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0x96b0de0, 0x9fc0000, {0x8b9ae8a, 0x121}, 0x8c94be4, {0x0, 0x0, 0x0})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x410
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage(0x9fc0000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:897 +0x78
testing.tRunner(0x9fc0000, 0x8c94be8)

— watchflakes

@gopherbot gopherbot reopened this Jul 10, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRenamePackage_InternalPackage"
2023-07-10 15:34 darwin-amd64-12_0 tools@ef125454 go@5fa6923b x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage (log) 
serve.go:432: debug server listening at http://localhost:49255
serve.go:432: debug server listening at http://localhost:49256
panic: test timed out after 10m0s

testing.(*T).Run(0xc0014149c0, {0x100be6d6d?, 0x100c03fea?}, 0xc004996b40)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000351720, 0xc0014149c0, {0x100c5ae00, 0x121}, 0x100d6c010, {0x0, 0x0, 0xc00324df60?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x4e5
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/misc.TestRenamePackage_InternalPackage(0xc002117860?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/rename_test.go:897 +0x5b
testing.tRunner(0xc0014149c0, 0x100d6c018)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jul 10, 2023

Still on release-branch.go1.19 (see #59483).

@findleyr
Copy link
Member

Closing as stale.

@golang golang locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr