net/http: TestQuerySemicolon failures

[gopherbot]

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon" && date < "2023-08-01"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h1 (0.13s)
        --- FAIL: TestQuerySemicolon/h1/?a=1;x=bad&x=good/allow=false (0.01s)
            serve_test.go:6585: expected error mentioning semicolons from ParseForm, got <nil>

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon"

2023-03-13 14:20 dragonfly-amd64-622 go@b6f29d23 net/http.TestQuerySemicolon (log)

--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h1 (0.13s)
        --- FAIL: TestQuerySemicolon/h1/?a=1;x=bad&x=good/allow=false (0.01s)
            serve_test.go:6585: expected error mentioning semicolons from ParseForm, got <nil>

— watchflakes

[bcmills]

(attn @neild)

I think the failure in TestQuerySemilcolon is actually a symptom of #56421. The second request in TestServerShutdown goes to a server that has already been shut down, but nothing prevents that request from going to some other server that is subsequently opened on the same port. Probably in this case that “some other server” is the one opened for TestQuerySemicolon.

[bcmills]

Duplicate of #56421

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon"

2023-08-22 20:48 linux-s390x-ibm-race go@a65b4904 net/http.TestQuerySemicolon (log)

--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h2 (3.14s)
        --- FAIL: TestQuerySemicolon/h2/?a=1%3Bx=bad&x=good%3B/allow=true (2.50s)
            serve_test.go:6583: Get "https://127.0.0.1:35513?a=1%3Bx=bad&x=good%3B": read tcp 127.0.0.1:51280->127.0.0.1:35513: read: connection reset by peer

— watchflakes