-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/dist: make.bash --no-clean fails when compilation target doesn't support regabi #47204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FWIW, @bcmills (or @mdempsky ), is this part of the build your domain?
|
I'm still investigating this and don't have any obvious/simple fix just yet. Before I dig too much further, what's the use case for /cc @ianlancetaylor |
The use-case appears to have been for getting the cross-compiler toolchain setup. Removing the flag from our setup appears to be an option. |
@mrutter-amzn Thanks. To clarify, you're talking about the same setup that @rhysh originally reported about? Or a separate one? |
The
So basically I think it's to make the build faster. And it may be the case that it does make the build slightly faster even today, as it doesn't have to relink the host binaries. I assume the problem with |
Yes, same issue. The build script @mrutter-amzn and I are debugging has specified that flag for several years, but removing it allows the build to succeed—and for the resulting toolchain to work as we need. I don't know how much duplicate compile/link time we'd save if the flag worked. |
I tried removing
Are there extra steps that cmd/dist needs to perform when compiling/linking binaries that use regabi? |
SGTM, thanks. FYI, my recommendation would be to just run "make.bash" once normally to build the host tools, and then run "GOARCH=... GOOS=... go install std" to pre-compile the standard library for each target platform that you're interested in. That should be even faster than With Go 1.16.6:
|
I just checked, and
and
install the same list of file names in It seems like a bug that they're not generating identical files, but I'm assuming the differences are just build IDs or file paths or something. Either way, I think just using sha256sum diff
|
Does anyone else want to weigh in on what to do with /cc @rsc @ianlancetaylor |
Change https://golang.org/cl/341392 mentions this issue: |
I don't care about the |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
This problem is present in go1.17rc1 and tip. It is not present in go1.16.6.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
What did you see instead?
The text was updated successfully, but these errors were encountered: