Skip to content

std: fix coding style issues reported by golint #45630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
perillo opened this issue Apr 19, 2021 · 3 comments
Closed

std: fix coding style issues reported by golint #45630

perillo opened this issue Apr 19, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@perillo
Copy link
Contributor

perillo commented Apr 19, 2021

golint std reported several coding style issues on the std module.
I have removed reports about exported entity without a comment, names with underscore and names with ALL_CAPS.

/usr/lib/go/src/cmd/doc/pkg.go:121:1: comment on exported method Package.Fatalf should be of the form "Fatalf ..."
/usr/lib/go/src/cmd/link/dwarf_test.go:139:11: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/cmd/trace/trace.go:187:6: func httpJsonTrace should be httpJSONTrace
/usr/lib/go/src/cmd/trace/trace.go:845:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/archive/tar/common.go:99:2: const paxUid should be paxUID
/usr/lib/go/src/archive/tar/common.go:151:2: struct field Uid should be UID
/usr/lib/go/src/archive/zip/reader.go:650:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:651:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:652:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:653:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:654:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:655:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:656:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:658:1: receiver name f should be consistent with previous receiver name e for fileListEntry
/usr/lib/go/src/archive/zip/reader.go:673:1: receiver name r should be consistent with previous receiver name z for Reader
/usr/lib/go/src/archive/zip/reader.go:701:1: receiver name r should be consistent with previous receiver name z for Reader
/usr/lib/go/src/archive/zip/reader.go:735:1: receiver name r should be consistent with previous receiver name z for Reader
/usr/lib/go/src/archive/zip/reader.go:755:1: receiver name r should be consistent with previous receiver name z for Reader
/usr/lib/go/src/compress/flate/huffman_bit_writer.go:359:97: method parameter isEof should be isEOF
/usr/lib/go/src/compress/flate/huffman_bit_writer.go:403:58: method parameter isEof should be isEOF
/usr/lib/go/src/compress/flate/huffman_bit_writer.go:417:45: method parameter isEof should be isEOF
/usr/lib/go/src/compress/flate/inflate.go:258:1: comment on exported type Reader should be of the form "Reader ..." (with optional leading article)
/usr/lib/go/src/compress/gzip/gunzip.go:47:1: comment on exported type Header should be of the form "Header ..." (with optional leading article)
/usr/lib/go/src/context/context.go:157:5: error var Canceled should have name of the form ErrFoo
/usr/lib/go/src/crypto/aes/cipher.go:13:1: comment on exported const BlockSize should be of the form "BlockSize ..."
/usr/lib/go/src/crypto/des/cipher.go:14:1: comment on exported const BlockSize should be of the form "BlockSize ..."
/usr/lib/go/src/crypto/ed25519/internal/edwards25519/edwards25519.go:59:1: comment on exported function FeCMove should be of the form "FeCMove ..."
/usr/lib/go/src/crypto/ed25519/internal/edwards25519/edwards25519.go:1018:1: comment on exported function ScMulAdd should be of the form "ScMulAdd ..."
/usr/lib/go/src/crypto/ed25519/internal/edwards25519/edwards25519.go:1451:1: comment on exported function ScReduce should be of the form "ScReduce ..."
/usr/lib/go/src/crypto/md5/md5.go:24:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/crypto/md5/md5.go:27:1: comment on exported const BlockSize should be of the form "BlockSize ..."
/usr/lib/go/src/crypto/rc4/rc4.go:72:3: should replace i += 1 with i++
/usr/lib/go/src/crypto/rsa/pkcs1v15.go:19:1: comment on exported type PKCS1v15DecryptOptions should be of the form "PKCS1v15DecryptOptions ..." (with optional leading article)
/usr/lib/go/src/crypto/rsa/rsa.go:174:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/crypto/sha1/sha1.go:22:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/crypto/sha1/sha1.go:25:1: comment on exported const BlockSize should be of the form "BlockSize ..."
/usr/lib/go/src/crypto/sha256/sha256.go:21:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/crypto/sha256/sha256.go:24:1: comment on exported const Size224 should be of the form "Size224 ..."
/usr/lib/go/src/crypto/sha256/sha256.go:27:1: comment on exported const BlockSize should be of the form "BlockSize ..."
/usr/lib/go/src/crypto/tls/common.go:36:2: comment on exported const VersionSSL30 should be of the form "VersionSSL30 ..."
/usr/lib/go/src/crypto/tls/common.go:374:2: comment on exported const PKCS1WithSHA256 should be of the form "PKCS1WithSHA256 ..."
/usr/lib/go/src/crypto/tls/common.go:379:2: comment on exported const PSSWithSHA256 should be of the form "PSSWithSHA256 ..."
/usr/lib/go/src/crypto/tls/common.go:384:2: comment on exported const ECDSAWithP256AndSHA256 should be of the form "ECDSAWithP256AndSHA256 ..."
/usr/lib/go/src/crypto/tls/common.go:389:2: comment on exported const Ed25519 should be of the form "Ed25519 ..."
/usr/lib/go/src/crypto/tls/common.go:392:2: comment on exported const PKCS1WithSHA1 should be of the form "PKCS1WithSHA1 ..."
/usr/lib/go/src/crypto/tls/conn_test.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/crypto/tls/handshake_client.go:45:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/crypto/tls/handshake_client.go:88:9: range var suiteId should be suiteID
/usr/lib/go/src/crypto/tls/handshake_client_test.go:1993:5: error var brokenConnErr should have name of the form errFoo
/usr/lib/go/src/crypto/tls/handshake_messages.go:73:2: struct field sessionId should be sessionID
/usr/lib/go/src/crypto/tls/handshake_messages.go:309:3: should replace bindersLen += 1 with bindersLen++
/usr/lib/go/src/crypto/tls/handshake_messages.go:596:2: struct field sessionId should be sessionID
/usr/lib/go/src/crypto/tls/handshake_messages_test.go:124:4: should replace cs += 1 with cs++
/usr/lib/go/src/crypto/x509/pem_decrypt.go:110:5: error var IncorrectPasswordError should have name of the form ErrFoo
/usr/lib/go/src/crypto/x509/x509.go:157:2: struct field UniqueId should be UniqueID
/usr/lib/go/src/crypto/x509/x509.go:158:2: struct field SubjectUniqueId should be SubjectUniqueID
/usr/lib/go/src/crypto/x509/x509.go:177:6: type authKeyId should be authKeyID
/usr/lib/go/src/crypto/x509/x509.go:178:2: struct field Id should be ID
/usr/lib/go/src/crypto/x509/x509.go:698:2: struct field SubjectKeyId should be SubjectKeyID
/usr/lib/go/src/crypto/x509/x509.go:699:2: struct field AuthorityKeyId should be AuthorityKeyID
/usr/lib/go/src/crypto/x509/x509.go:734:1: comment on exported type InsecureAlgorithmError should be of the form "InsecureAlgorithmError ..." (with optional leading article)
/usr/lib/go/src/crypto/x509/x509.go:846:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/crypto/x509/x509.go:1522:6: func parseSubjectKeyIdExtension should be parseSubjectKeyIDExtension
/usr/lib/go/src/crypto/x509/x509.go:1615:2: var oidExtensionSubjectKeyId should be oidExtensionSubjectKeyID
/usr/lib/go/src/crypto/x509/x509.go:1618:2: var oidExtensionAuthorityKeyId should be oidExtensionAuthorityKeyID
/usr/lib/go/src/crypto/x509/x509.go:1689:70: func parameter authorityKeyId should be authorityKeyID
/usr/lib/go/src/crypto/x509/x509.go:1689:93: func parameter subjectKeyId should be subjectKeyID
/usr/lib/go/src/crypto/x509/x509.go:2174:2: var authorityKeyId should be authorityKeyID
/usr/lib/go/src/crypto/x509/x509.go:2179:2: var subjectKeyId should be subjectKeyID
/usr/lib/go/src/crypto/x509/x509.go:2459:3: struct field Id should be ID
/usr/lib/go/src/crypto/x509/x509_test.go:1583:3: struct field Id should be ID
/usr/lib/go/src/crypto/x509/pkix/pkix.go:114:2: struct field Id should be ID
/usr/lib/go/src/database/sql/sql_test.go:4281:5: error var pingError should have name of the form errFoo
/usr/lib/go/src/database/sql/driver/driver.go:97:1: comment on exported type DriverContext should be of the form "DriverContext ..." (with optional leading article)
/usr/lib/go/src/database/sql/driver/driver.go:103:6: type name will be used as driver.DriverContext by other packages, and that stutters; consider calling this Context
/usr/lib/go/src/database/sql/driver/types.go:263:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/debug/dwarf/buf.go:110:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/debug/dwarf/const.go:74:2: comment on exported const AttrAllocated should be of the form "AttrAllocated ..."
/usr/lib/go/src/debug/dwarf/const.go:102:2: comment on exported const AttrSignature should be of the form "AttrSignature ..."
/usr/lib/go/src/debug/dwarf/const.go:109:2: comment on exported const AttrStringLengthBitSize should be of the form "AttrStringLengthBitSize ..."
/usr/lib/go/src/debug/dwarf/const.go:257:2: comment on exported const TagDwarfProcedure should be of the form "TagDwarfProcedure ..."
/usr/lib/go/src/debug/dwarf/const.go:269:2: comment on exported const TagTypeUnit should be of the form "TagTypeUnit ..."
/usr/lib/go/src/debug/dwarf/const.go:273:2: comment on exported const TagCoarrayType should be of the form "TagCoarrayType ..."
/usr/lib/go/src/debug/dwarf/entry.go:231:1: comment on exported type Entry should be of the form "Entry ..." (with optional leading article)
/usr/lib/go/src/debug/dwarf/entry.go:320:2: comment on exported const ClassRangeListPtr should be of the form "ClassRangeListPtr ..."
/usr/lib/go/src/debug/dwarf/type.go:44:1: receiver name t should be consistent with previous receiver name b for BasicType
/usr/lib/go/src/debug/elf/elf.go:64:1: comment on exported const ELFMAG should be of the form "ELFMAG ..."
/usr/lib/go/src/debug/elf/elf.go:388:2: comment on exported const EM_486 should be of the form "EM_486 ..."
/usr/lib/go/src/debug/elf/elf.go:589:1: comment on exported type SectionIndex should be of the form "SectionIndex ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:617:1: comment on exported type SectionType should be of the form "SectionType ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:686:1: comment on exported type SectionFlag should be of the form "SectionFlag ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:722:1: comment on exported type CompressionType should be of the form "CompressionType ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:744:1: comment on exported type ProgType should be of the form "ProgType ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:824:1: comment on exported type ProgFlag should be of the form "ProgFlag ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:844:1: comment on exported type DynTag should be of the form "DynTag ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1077:1: comment on exported type DynFlag should be of the form "DynFlag ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1124:1: comment on exported type SymBind should be of the form "SymBind ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1150:1: comment on exported type SymType should be of the form "SymType ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1184:1: comment on exported type SymVis should be of the form "SymVis ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1208:1: comment on exported type R_X86_64 should be of the form "R_X86_64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1306:1: comment on exported type R_AARCH64 should be of the form "R_AARCH64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1578:1: comment on exported type R_ALPHA should be of the form "R_ALPHA ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1646:1: comment on exported type R_ARM should be of the form "R_ARM ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:1946:1: comment on exported type R_386 should be of the form "R_386 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2042:1: comment on exported type R_MIPS should be of the form "R_MIPS ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2151:1: comment on exported type R_PPC should be of the form "R_PPC ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2322:1: comment on exported type R_PPC64 should be of the form "R_PPC64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2549:1: comment on exported type R_RISCV should be of the form "R_RISCV ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2669:1: comment on exported type R_390 should be of the form "R_390 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2803:1: comment on exported type R_SPARC should be of the form "R_SPARC ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2927:1: comment on exported const ARM_MAGIC_TRAMP_NUMBER should be of the form "ARM_MAGIC_TRAMP_NUMBER ..."
/usr/lib/go/src/debug/elf/elf.go:2930:1: comment on exported type Header32 should be of the form "Header32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2948:1: comment on exported type Section32 should be of the form "Section32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2962:1: comment on exported type Prog32 should be of the form "Prog32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2974:1: comment on exported type Dyn32 should be of the form "Dyn32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2980:1: comment on exported type Chdr32 should be of the form "Chdr32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2991:1: comment on exported type Rel32 should be of the form "Rel32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:2997:1: comment on exported type Rela32 should be of the form "Rela32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3008:1: comment on exported type Sym32 should be of the form "Sym32 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3031:1: comment on exported type Header64 should be of the form "Header64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3049:1: comment on exported type Section64 should be of the form "Section64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3063:1: comment on exported type Prog64 should be of the form "Prog64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3075:1: comment on exported type Dyn64 should be of the form "Dyn64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3081:1: comment on exported type Chdr64 should be of the form "Chdr64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3093:1: comment on exported type Rel64 should be of the form "Rel64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3099:1: comment on exported type Rela64 should be of the form "Rela64 ..." (with optional leading article)
/usr/lib/go/src/debug/elf/elf.go:3110:1: comment on exported type Sym64 should be of the form "Sym64 ..." (with optional leading article)
/usr/lib/go/src/debug/macho/fat.go:23:2: struct field Cpu should be CPU
/usr/lib/go/src/debug/macho/fat.go:24:2: struct field SubCpu should be SubCPU
/usr/lib/go/src/debug/macho/fat.go:62:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/debug/macho/macho.go:20:2: struct field Cpu should be CPU
/usr/lib/go/src/debug/macho/macho.go:21:2: struct field SubCpu should be SubCPU
/usr/lib/go/src/debug/macho/macho.go:60:6: type Cpu should be CPU
/usr/lib/go/src/debug/macho/macho.go:65:2: const Cpu386 should be CPU386
/usr/lib/go/src/debug/macho/macho.go:66:2: const CpuAmd64 should be CPUAmd64
/usr/lib/go/src/debug/macho/macho.go:67:2: const CpuArm should be CPUArm
/usr/lib/go/src/debug/macho/macho.go:68:2: const CpuArm64 should be CPUArm64
/usr/lib/go/src/debug/macho/macho.go:69:2: const CpuPpc should be CPUPpc
/usr/lib/go/src/debug/macho/macho.go:70:2: const CpuPpc64 should be CPUPpc64
/usr/lib/go/src/debug/pe/file.go:78:27: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/debug/pe/file.go:91:26: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/debug/plan9obj/file.go:69:1: comment on exported type Sym should be of the form "Sym ..." (with optional leading article)
/usr/lib/go/src/encoding/binary/varint.go:103:5: error var overflow should have name of the form errFoo
/usr/lib/go/src/encoding/gob/decode.go:670:2: var concreteId should be concreteID
/usr/lib/go/src/encoding/gob/decode.go:790:30: method parameter wireId should be wireID
/usr/lib/go/src/encoding/gob/decode.go:814:4: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:823:4: var keyId should be keyID
/usr/lib/go/src/encoding/gob/decode.go:824:4: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:838:8: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:875:36: method parameter wireId should be wireID
/usr/lib/go/src/encoding/gob/decode.go:898:4: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:905:4: var keyId should be keyID
/usr/lib/go/src/encoding/gob/decode.go:906:4: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:914:4: var elemId should be elemID
/usr/lib/go/src/encoding/gob/decode.go:1040:32: method parameter remoteId should be remoteID
/usr/lib/go/src/encoding/gob/decode.go:1052:35: method parameter remoteId should be remoteID
/usr/lib/go/src/encoding/gob/decode.go:1073:41: method parameter remoteId should be remoteID
/usr/lib/go/src/encoding/gob/decode.go:1085:32: method parameter remoteId should be remoteID
/usr/lib/go/src/encoding/gob/decode.go:1136:37: method parameter remoteId should be remoteID
/usr/lib/go/src/encoding/gob/decode.go:1161:40: method parameter wireId should be wireID
/usr/lib/go/src/encoding/gob/decode.go:1181:33: method parameter wireId should be wireID
/usr/lib/go/src/encoding/gob/decode.go:1212:40: method parameter wireId should be wireID
/usr/lib/go/src/encoding/gob/encoder.go:210:21: method sendTypeId should be sendTypeID
/usr/lib/go/src/encoding/gob/encoder_test.go:504:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
/usr/lib/go/src/encoding/gob/encoder_test.go:667:2: struct field Id should be ID
/usr/lib/go/src/encoding/gob/type.go:161:6: type typeId should be typeID
/usr/lib/go/src/encoding/gob/type.go:163:5: var nextId should be nextID
/usr/lib/go/src/encoding/gob/type.go:165:7: const firstUserId should be firstUserID
/usr/lib/go/src/encoding/gob/type.go:177:5: var builtinIdToType should be builtinIDToType
/usr/lib/go/src/encoding/gob/type.go:179:6: func setTypeId should be setTypeID
/usr/lib/go/src/encoding/gob/type.go:218:2: struct field Id should be ID
/usr/lib/go/src/encoding/gob/type.go:223:22: method setId should be setID
/usr/lib/go/src/encoding/gob/type.go:399:2: struct field Id should be ID
/usr/lib/go/src/encoding/gob/type.go:605:6: func checkId should be checkID
/usr/lib/go/src/encoding/gob/type.go:784:6: type name will be used as gob.GobEncoder by other packages, and that stutters; consider calling this Encoder
/usr/lib/go/src/encoding/gob/type.go:793:6: type name will be used as gob.GobDecoder by other packages, and that stutters; consider calling this Decoder
/usr/lib/go/src/encoding/json/encode.go:250:1: comment on exported type InvalidUTF8Error should be of the form "InvalidUTF8Error ..." (with optional leading article)
/usr/lib/go/src/encoding/json/stream_test.go:243:3: struct field Id should be ID
/usr/lib/go/src/encoding/json/stream_test.go:267:3: struct field Id should be ID
/usr/lib/go/src/encoding/json/stream_test.go:268:3: struct field IdPtr should be IDPtr
/usr/lib/go/src/flag/flag.go:5:1: package comment should not have leading space
/usr/lib/go/src/flag/flag.go:326:6: type name will be used as flag.FlagSet by other packages, and that stutters; consider calling this Set
/usr/lib/go/src/fmt/doc.go:5:1: package comment should not have leading space
/usr/lib/go/src/fmt/print.go:89:1: receiver name bp should be consistent with previous receiver name b for buffer
/usr/lib/go/src/fmt/scan.go:465:5: error var complexError should have name of the form errFoo
/usr/lib/go/src/fmt/scan.go:466:5: error var boolError should have name of the form errFoo
/usr/lib/go/src/go/ast/ast.go:32:1: comment on exported type Node should be of the form "Node ..." (with optional leading article)
/usr/lib/go/src/go/ast/ast.go:38:1: comment on exported type Expr should be of the form "Expr ..." (with optional leading article)
/usr/lib/go/src/go/ast/ast.go:44:1: comment on exported type Stmt should be of the form "Stmt ..." (with optional leading article)
/usr/lib/go/src/go/ast/ast.go:50:1: comment on exported type Decl should be of the form "Decl ..." (with optional leading article)
/usr/lib/go/src/go/ast/ast.go:406:1: comment on exported type ChanDir should be of the form "ChanDir ..." (with optional leading article)
/usr/lib/go/src/go/ast/ast.go:576:1: receiver name id should be consistent with previous receiver name x for Ident
/usr/lib/go/src/go/ast/ast.go:578:1: receiver name id should be consistent with previous receiver name x for Ident
/usr/lib/go/src/go/ast/ast.go:646:3: struct field Lhs should be LHS
/usr/lib/go/src/go/ast/ast.go:649:3: struct field Rhs should be RHS
/usr/lib/go/src/go/ast/filter.go:306:2: comment on exported const FilterFuncDuplicates should be of the form "FilterFuncDuplicates ..."
/usr/lib/go/src/go/ast/filter.go:308:2: comment on exported const FilterUnassociatedComments should be of the form "FilterUnassociatedComments ..."
/usr/lib/go/src/go/ast/filter.go:311:2: comment on exported const FilterImportDuplicates should be of the form "FilterImportDuplicates ..."
/usr/lib/go/src/go/ast/walk.go:9:1: comment on exported type Visitor should be of the form "Visitor ..." (with optional leading article)
/usr/lib/go/src/go/build/build.go:350:2: comment on exported const FindOnly should be of the form "FindOnly ..."
/usr/lib/go/src/go/build/build.go:355:2: comment on exported const AllowBinary should be of the form "AllowBinary ..."
/usr/lib/go/src/go/build/build.go:366:2: comment on exported const ImportComment should be of the form "ImportComment ..."
/usr/lib/go/src/go/build/build.go:372:2: comment on exported const IgnoreVendor should be of the form "IgnoreVendor ..."
/usr/lib/go/src/go/build/build.go:1167:21: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/go/build/build.go:1172:21: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/go/constant/value.go:30:2: comment on exported const Unknown should be of the form "Unknown ..."
/usr/lib/go/src/go/constant/value.go:33:2: comment on exported const Bool should be of the form "Bool ..."
/usr/lib/go/src/go/constant/value.go:37:2: comment on exported const Int should be of the form "Int ..."
/usr/lib/go/src/go/constant/value.go:1082:15: func parameter x_ should be x
/usr/lib/go/src/go/constant/value.go:1082:41: func parameter y_ should be y
/usr/lib/go/src/go/constant/value.go:1318:14: func parameter x_ should be x
/usr/lib/go/src/go/constant/value.go:1318:40: func parameter y_ should be y
/usr/lib/go/src/go/internal/gccgoimporter/gccgoinstallation.go:16:1: comment on exported type GccgoInstallation should be of the form "GccgoInstallation ..." (with optional leading article)
/usr/lib/go/src/go/internal/gccgoimporter/gccgoinstallation.go:28:1: comment on exported method GccgoInstallation.InitFromDriver should be of the form "InitFromDriver ..."
/usr/lib/go/src/go/internal/gccgoimporter/gccgoinstallation.go:70:1: comment on exported method GccgoInstallation.SearchPaths should be of the form "SearchPaths ..."
/usr/lib/go/src/go/internal/gccgoimporter/gccgoinstallation.go:93:1: comment on exported method GccgoInstallation.GetImporter should be of the form "GetImporter ..."
/usr/lib/go/src/go/internal/gccgoimporter/importer.go:27:1: comment on exported type InitData should be of the form "InitData ..." (with optional leading article)
/usr/lib/go/src/go/internal/srcimporter/srcimporter.go:33:1: comment on exported function New should be of the form "New ..."
/usr/lib/go/src/go/internal/srcimporter/srcimporter.go:52:1: comment on exported method Importer.Import should be of the form "Import ..."
/usr/lib/go/src/go/parser/parser.go:59:2: struct field inRhs should be inRHS
/usr/lib/go/src/go/parser/parser.go:590:18: method parseLhsList should be parseLHSList
/usr/lib/go/src/go/parser/parser.go:618:18: method parseRhsList should be parseRHSList
/usr/lib/go/src/go/parser/parser.go:1639:18: method parseRhs should be parseRHS
/usr/lib/go/src/go/parser/parser.go:1647:18: method parseRhsOrType should be parseRHSOrType
/usr/lib/go/src/go/scanner/errors.go:14:1: comment on exported type Error should be of the form "Error ..." (with optional leading article)
/usr/lib/go/src/go/scanner/scanner.go:97:1: comment on exported type Mode should be of the form "Mode ..." (with optional leading article)
/usr/lib/go/src/go/token/position.go:81:1: comment on exported const NoPos should be of the form "NoPos ..."
/usr/lib/go/src/go/token/token.go:263:1: receiver name op should be consistent with previous receiver name tok for Token
/usr/lib/go/src/go/types/api.go:340:2: struct field Lhs should be LHS
/usr/lib/go/src/go/types/api.go:341:2: struct field Rhs should be RHS
/usr/lib/go/src/go/types/check.go:37:2: struct field isLhs should be isLHS
/usr/lib/go/src/go/types/initorder.go:112:3: var infoLhs should be infoLHS
/usr/lib/go/src/go/types/object.go:60:6: func Id should be ID
/usr/lib/go/src/go/types/object.go:144:20: method Id should be ID
/usr/lib/go/src/go/types/object.go:156:20: method sameId should be sameID
/usr/lib/go/src/go/types/object.go:253:1: comment on exported type Var should be of the form "Var ..." (with optional leading article)
/usr/lib/go/src/go/types/operand.go:276:11: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/go/types/package.go:44:1: comment on exported method Package.Complete should be of the form "Complete ..."
/usr/lib/go/src/go/types/type.go:25:2: comment on exported const Bool should be of the form "Bool ..."
/usr/lib/go/src/go/types/type.go:45:2: comment on exported const UntypedBool should be of the form "UntypedBool ..."
/usr/lib/go/src/go/types/type.go:54:2: comment on exported const Byte should be of the form "Byte ..."
/usr/lib/go/src/go/types/typexpr.go:263:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/go/types/universe.go:15:1: comment on exported var Universe should be of the form "Universe ..."
/usr/lib/go/src/go/types/universe.go:19:1: comment on exported var Unsafe should be of the form "Unsafe ..."
/usr/lib/go/src/go/types/universe.go:110:6: type builtinId should be builtinID
/usr/lib/go/src/hash/adler32/adler32.go:29:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/hash/crc32/crc32.go:22:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/hash/crc64/crc64.go:16:1: comment on exported const Size should be of the form "Size ..."
/usr/lib/go/src/html/template/exec_test.go:233:5: error var myError should have name of the form errFoo
/usr/lib/go/src/html/template/exec_test.go:1313:5: error var alwaysError should have name of the form errFoo
/usr/lib/go/src/html/template/template.go:34:5: error var escapeOK should have name of the form errFoo
/usr/lib/go/src/image/draw/draw.go:106:6: func name will be used as draw.DrawMask by other packages, and that stutters; consider calling this Mask
/usr/lib/go/src/image/jpeg/reader.go:92:1: comment on exported type Reader should be of the form "Reader ..." (with optional leading article)
/usr/lib/go/src/image/png/writer.go:420:6: should replace i += 1 with i++
/usr/lib/go/src/image/png/writer.go:435:6: should replace i += 1 with i++
/usr/lib/go/src/internal/bytealg/compare_native.go:11:1: comment on exported function Compare should be of the form "Compare ..."
/usr/lib/go/src/internal/bytealg/count_native.go:9:1: comment on exported function Count should be of the form "Count ..."
/usr/lib/go/src/internal/bytealg/count_native.go:12:1: comment on exported function CountString should be of the form "CountString ..."
/usr/lib/go/src/internal/bytealg/indexbyte_native.go:9:1: comment on exported function IndexByte should be of the form "IndexByte ..."
/usr/lib/go/src/internal/bytealg/indexbyte_native.go:12:1: comment on exported function IndexByteString should be of the form "IndexByteString ..."
/usr/lib/go/src/internal/cpu/cpu.go:22:1: comment on exported var X86 should be of the form "X86 ..."
/usr/lib/go/src/internal/cpu/cpu.go:47:1: comment on exported var ARM should be of the form "ARM ..."
/usr/lib/go/src/internal/cpu/cpu.go:56:1: comment on exported var ARM64 should be of the form "ARM64 ..."
/usr/lib/go/src/internal/cpu/cpu.go:78:1: comment on exported var PPC64 should be of the form "PPC64 ..."
/usr/lib/go/src/internal/singleflight/singleflight.go:47:1: error should be the last type when returning multiple items
/usr/lib/go/src/internal/trace/gc.go:644:1: receiver name c should be consistent with previous receiver name s for mmuSeries
/usr/lib/go/src/internal/trace/gc.go:708:1: receiver name c should be consistent with previous receiver name s for mmuSeries
/usr/lib/go/src/internal/trace/parser.go:19:2: a blank import should be only in a main or test package, or have a comment justifying it
/usr/lib/go/src/internal/trace/parser.go:72:2: comment on exported const FakeP should be of the form "FakeP ..."
/usr/lib/go/src/internal/xcoff/ar.go:22:2: comment on exported const FL_HSZ_BIG should be of the form "FL_HSZ_BIG ..."
/usr/lib/go/src/internal/xcoff/ar.go:57:1: comment on exported type ArchiveHeader should be of the form "ArchiveHeader ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/ar.go:220:1: receiver name arch should be consistent with previous receiver name a for Archive
/usr/lib/go/src/internal/xcoff/xcoff.go:7:1: comment on exported type FileHeader32 should be of the form "FileHeader32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:51:1: comment on exported type SectionHeader32 should be of the form "SectionHeader32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:108:1: comment on exported type SymEnt32 should be of the form "SymEnt32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:130:2: comment on exported const N_DEBUG should be of the form "N_DEBUG ..."
/usr/lib/go/src/internal/xcoff/xcoff.go:135:2: comment on exported const SYM_V_INTERNAL should be of the form "SYM_V_INTERNAL ..."
/usr/lib/go/src/internal/xcoff/xcoff.go:174:1: comment on exported type AuxFile64 should be of the form "AuxFile64 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:181:1: comment on exported type AuxFcn32 should be of the form "AuxFcn32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:204:1: comment on exported type AuxCSect32 should be of the form "AuxCSect32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:275:1: comment on exported type LoaderHeader32 should be of the form "LoaderHeader32 ..." (with optional leading article)
/usr/lib/go/src/internal/xcoff/xcoff.go:305:1: comment on exported type LoaderSymbol32 should be of the form "LoaderSymbol32 ..." (with optional leading article)
/usr/lib/go/src/io/io.go:44:5: error var EOF should have name of the form ErrFoo
/usr/lib/go/src/io/fs/walk.go:15:5: error var SkipDir should have name of the form ErrFoo
/usr/lib/go/src/log/syslog/syslog.go:32:2: comment on exported const LOG_EMERG should be of the form "LOG_EMERG ..."
/usr/lib/go/src/log/syslog/syslog.go:47:2: comment on exported const LOG_KERN should be of the form "LOG_KERN ..."
/usr/lib/go/src/math/big/bits_test.go:161:1: receiver name bits should be consistent with previous receiver name x for Bits
/usr/lib/go/src/math/big/decimal.go:55:1: receiver name x should be consistent with previous receiver name d for decimal
/usr/lib/go/src/math/big/decimal.go:160:1: receiver name x should be consistent with previous receiver name d for decimal
/usr/lib/go/src/math/big/decimal.go:214:1: receiver name x should be consistent with previous receiver name d for decimal
/usr/lib/go/src/math/big/decimal.go:226:1: receiver name x should be consistent with previous receiver name d for decimal
/usr/lib/go/src/math/big/decimal.go:251:1: receiver name x should be consistent with previous receiver name d for decimal
/usr/lib/go/src/math/big/float.go:22:1: comment on exported type Float should be of the form "Float ..." (with optional leading article)
/usr/lib/go/src/math/big/float.go:208:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:215:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:223:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:230:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:240:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:268:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:334:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:339:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:345:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:362:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:733:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:778:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:833:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:953:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:1074:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:1130:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:1379:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:1674:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/float.go:1709:1: receiver name x should be consistent with previous receiver name z for Float
/usr/lib/go/src/math/big/floatmarsh.go:64:1: receiver name z should be consistent with previous receiver name x for Float
/usr/lib/go/src/math/big/floatmarsh.go:113:1: receiver name z should be consistent with previous receiver name x for Float
/usr/lib/go/src/math/big/int.go:49:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:61:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:73:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:95:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:102:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:109:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:116:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:137:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:158:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:176:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:197:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:211:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:220:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:238:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:247:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:264:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:296:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:424:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:430:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:443:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:488:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:531:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:671:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:794:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:808:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:897:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:910:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:930:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:981:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1008:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1015:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1055:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1072:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1102:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1135:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1165:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1195:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/int.go:1211:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/intconv.go:182:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/intconv.go:238:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/intmarsh.go:33:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/intmarsh.go:57:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/intmarsh.go:74:1: receiver name z should be consistent with previous receiver name x for Int
/usr/lib/go/src/math/big/nat.go:153:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:745:1: receiver name q should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:967:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:976:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:1071:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:1082:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/nat.go:1179:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/natconv.go:259:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/natconv.go:264:1: receiver name x should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/natconv.go:370:1: receiver name q should be consistent with previous receiver name z for nat
/usr/lib/go/src/math/big/rat.go:273:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:289:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:396:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:401:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:409:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:420:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/rat.go:486:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/ratconv.go:295:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/ratconv.go:300:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/ratconv.go:314:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/ratconv.go:324:1: receiver name x should be consistent with previous receiver name z for Rat
/usr/lib/go/src/math/big/ratmarsh.go:42:1: receiver name z should be consistent with previous receiver name x for Rat
/usr/lib/go/src/math/big/ratmarsh.go:69:1: receiver name z should be consistent with previous receiver name x for Rat
/usr/lib/go/src/math/bits/bits_errors.go:9:8: a blank import should be only in a main or test package, or have a comment justifying it
/usr/lib/go/src/math/cmplx/exp.go:60:11: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/math/rand/rand_test.go:50:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
/usr/lib/go/src/mime/multipart/multipart.go:144:1: receiver name bp should be consistent with previous receiver name p for Part
/usr/lib/go/src/mime/multipart/multipart.go:381:1: receiver name mr should be consistent with previous receiver name r for Reader
/usr/lib/go/src/mime/multipart/multipart.go:390:1: receiver name mr should be consistent with previous receiver name r for Reader
/usr/lib/go/src/net/cgo_unix.go:56:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/cgo_unix.go:64:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/cgo_unix.go:222:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/cgo_unix.go:237:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/cgo_unix.go:265:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/conf.go:265:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/dial.go:162:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/dnsclient.go:171:1: receiver name addrs should be consistent with previous receiver name s for byPriorityWeight
/usr/lib/go/src/net/dnsclient.go:194:1: receiver name addrs should be consistent with previous receiver name s for byPriorityWeight
/usr/lib/go/src/net/lookup_test.go:1163:8: should not use basic type string as key in context.WithValue
/usr/lib/go/src/net/sendfile_linux.go:20:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/splice_linux.go:17:1: error should be the last type when returning multiple items
/usr/lib/go/src/net/unixsock.go:234:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:243:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:256:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:269:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:282:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:286:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock.go:303:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/unixsock_posix.go:205:1: receiver name l should be consistent with previous receiver name ln for UnixListener
/usr/lib/go/src/net/http/client.go:299:1: context.Context should be the first parameter of a function
/usr/lib/go/src/net/http/cookie.go:34:2: struct field HttpOnly should be HTTPOnly
/usr/lib/go/src/net/http/export_test.go:33:2: var ExportHttp2ConfigureServer should be ExportHTTP2ConfigureServer
/usr/lib/go/src/net/http/export_test.go:256:6: func ExportHttp2ConfigureTransport should be ExportHTTP2ConfigureTransport
/usr/lib/go/src/net/http/export_test.go:283:3: should replace states[st] += 1 with states[st]++
/usr/lib/go/src/net/http/fs.go:503:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/http/fs.go:567:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/http/request.go:56:2: comment on exported var ErrUnexpectedTrailer should be of the form "ErrUnexpectedTrailer ..."
/usr/lib/go/src/net/http/request.go:69:2: comment on exported var ErrHeaderTooLong should be of the form "ErrHeaderTooLong ..."
/usr/lib/go/src/net/http/request.go:74:2: comment on exported var ErrShortBody should be of the form "ErrShortBody ..."
/usr/lib/go/src/net/http/request.go:79:2: comment on exported var ErrMissingContentLength should be of the form "ErrMissingContentLength ..."
/usr/lib/go/src/net/http/request.go:1387:19: method wantsHttp10KeepAlive should be wantsHTTP10KeepAlive
/usr/lib/go/src/net/http/response.go:170:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/net/http/server.go:1616:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/http/server.go:2654:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:2660:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:2667:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:2779:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:2787:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:2811:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3066:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3083:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3096:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3103:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3110:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3114:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/server.go:3135:1: receiver name s should be consistent with previous receiver name srv for Server
/usr/lib/go/src/net/http/transfer.go:528:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/net/http/transport.go:1508:1: receiver name pconn should be consistent with previous receiver name pc for persistConn
/usr/lib/go/src/net/http/transport.go:2237:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/http/cookiejar/jar.go:98:2: struct field HttpOnly should be HTTPOnly
/usr/lib/go/src/net/http/fcgi/child.go:27:2: struct field reqId should be reqID
/usr/lib/go/src/net/http/fcgi/child.go:38:17: func parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:67:2: struct field Id should be ID
/usr/lib/go/src/net/http/fcgi/fcgi.go:92:40: method parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:139:1: receiver name r should be consistent with previous receiver name rec for record
/usr/lib/go/src/net/http/fcgi/fcgi.go:144:45: method parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:162:32: method parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:169:44: method parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:237:42: func parameter reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi.go:248:2: struct field reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi_test.go:47:2: struct field reqId should be reqID
/usr/lib/go/src/net/http/fcgi/fcgi_test.go:167:2: func parameter requestId should be requestID
/usr/lib/go/src/net/http/fcgi/fcgi_test.go:170:2: var requestIdB1 should be requestIDB1
/usr/lib/go/src/net/http/fcgi/fcgi_test.go:171:2: var requestIdB0 should be requestIDB0
/usr/lib/go/src/net/http/httputil/persist.go:18:2: comment on exported var ErrPersistEOF should be of the form "ErrPersistEOF ..."
/usr/lib/go/src/net/http/httputil/persist.go:21:2: comment on exported var ErrClosed should be of the form "ErrClosed ..."
/usr/lib/go/src/net/http/httputil/persist.go:24:2: comment on exported var ErrPipeline should be of the form "ErrPipeline ..."
/usr/lib/go/src/net/http/httputil/persist.go:150:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/net/rpc/server.go:5:1: package comment should not have leading space
/usr/lib/go/src/net/rpc/server.go:144:2: comment on exported const DefaultRPCPath should be of the form "DefaultRPCPath ..."
/usr/lib/go/src/net/rpc/server_test.go:31:2: const newHttpPath should be newHTTPPath
/usr/lib/go/src/net/rpc/server_test.go:151:6: func startHttpServer should be startHTTPServer
/usr/lib/go/src/net/rpc/jsonrpc/all_test.go:31:2: struct field Id should be ID
/usr/lib/go/src/net/rpc/jsonrpc/all_test.go:299:46: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/net/rpc/jsonrpc/client.go:49:2: struct field Id should be ID
/usr/lib/go/src/net/rpc/jsonrpc/client.go:63:2: struct field Id should be ID
/usr/lib/go/src/net/rpc/jsonrpc/server.go:49:2: struct field Id should be ID
/usr/lib/go/src/net/rpc/jsonrpc/server.go:59:2: struct field Id should be ID
/usr/lib/go/src/os/signal/internal/pty/pty.go:27:6: type name will be used as pty.PtyError by other packages, and that stutters; consider calling this Error
/usr/lib/go/src/os/user/cgo_lookup_unix.go:81:6: func lookupUserId should be lookupUserID
/usr/lib/go/src/os/user/cgo_lookup_unix.go:89:6: func lookupUnixUid should be lookupUnixUID
/usr/lib/go/src/os/user/cgo_lookup_unix.go:157:6: func lookupGroupId should be lookupGroupID
/usr/lib/go/src/os/user/lookup.go:41:6: func LookupId should be LookupID
/usr/lib/go/src/os/user/lookup.go:56:6: func LookupGroupId should be LookupGroupID
/usr/lib/go/src/os/user/user.go:34:2: struct field Uid should be UID
/usr/lib/go/src/os/user/user.go:62:6: type UnknownUserIdError should be UnknownUserIDError
/usr/lib/go/src/os/user/user.go:78:6: type UnknownGroupIdError should be UnknownGroupIDError
/usr/lib/go/src/regexp/syntax/compile.go:41:1: receiver name l1 should be consistent with previous receiver name l for patchList
/usr/lib/go/src/regexp/syntax/parse.go:29:2: comment on exported const ErrInternalError should be of the form "ErrInternalError ..."
/usr/lib/go/src/regexp/syntax/parse.go:32:2: comment on exported const ErrInvalidCharClass should be of the form "ErrInvalidCharClass ..."
/usr/lib/go/src/regexp/syntax/regexp.go:246:1: receiver name re should be consistent with previous receiver name x for Regexp
/usr/lib/go/src/regexp/syntax/regexp.go:293:1: receiver name re should be consistent with previous receiver name x for Regexp
/usr/lib/go/src/regexp/syntax/regexp.go:307:1: receiver name re should be consistent with previous receiver name x for Regexp
/usr/lib/go/src/regexp/syntax/regexp.go:313:1: receiver name re should be consistent with previous receiver name x for Regexp
/usr/lib/go/src/runtime/alg.go:112:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/alg.go:129:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/export_test.go:518:13: exported func Getg returns unexported type *runtime.g, which can be annoying to use
/usr/lib/go/src/runtime/malloc.go:940:4: should replace inittrace.allocs += 1 with inittrace.allocs++
/usr/lib/go/src/runtime/malloc.go:1417:3: should replace size -= 1 with size--
/usr/lib/go/src/runtime/mgc.go:1715:2: var sweepTermCpu should be sweepTermCPU
/usr/lib/go/src/runtime/mgc.go:1718:2: var markCpu should be markCPU
/usr/lib/go/src/runtime/mgc.go:1719:2: var markTermCpu should be markTermCPU
/usr/lib/go/src/runtime/mgc.go:1720:2: var cycleCpu should be cycleCPU
/usr/lib/go/src/runtime/mgc.go:1724:2: var totalCpu should be totalCPU
/usr/lib/go/src/runtime/mheap.go:580:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/mheap.go:588:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/mheap.go:1525:1: receiver name span should be consistent with previous receiver name s for mspan
/usr/lib/go/src/runtime/mheap.go:1545:1: receiver name span should be consistent with previous receiver name s for mspan
/usr/lib/go/src/runtime/mpagealloc.go:122:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/mpagealloc.go:131:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/mpagealloc.go:552:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/mranges.go:116:1: receiver name l1 should be consistent with previous receiver name l for offAddr
/usr/lib/go/src/runtime/mranges.go:122:1: receiver name l1 should be consistent with previous receiver name l for offAddr
/usr/lib/go/src/runtime/mranges.go:128:1: receiver name l1 should be consistent with previous receiver name l for offAddr
/usr/lib/go/src/runtime/mranges.go:133:1: receiver name l1 should be consistent with previous receiver name l for offAddr
/usr/lib/go/src/runtime/msize.go:17:10: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/rwmutex.go:45:5: should replace rw.readerPass -= 1 with rw.readerPass--
/usr/lib/go/src/runtime/rwmutex.go:117:3: should replace r -= 1 with r--
/usr/lib/go/src/runtime/time.go:325:11: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/time.go:344:11: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/runtime/cgo/mmap.go:10:8: a blank import should be only in a main or test package, or have a comment justifying it
/usr/lib/go/src/runtime/cgo/sigaction.go:10:8: a blank import should be only in a main or test package, or have a comment justifying it
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:14:1: comment on exported function Load should be of the form "Load ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:20:1: comment on exported function Loadp should be of the form "Loadp ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:26:1: comment on exported function Load64 should be of the form "Load64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:32:1: comment on exported function LoadAcq should be of the form "LoadAcq ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:38:1: comment on exported function LoadAcq64 should be of the form "LoadAcq64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:44:1: comment on exported function LoadAcquintptr should be of the form "LoadAcquintptr ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:50:1: comment on exported function Xadd should be of the form "Xadd ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:53:1: comment on exported function Xadd64 should be of the form "Xadd64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:56:1: comment on exported function Xadduintptr should be of the form "Xadduintptr ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:59:1: comment on exported function Xchg should be of the form "Xchg ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:62:1: comment on exported function Xchg64 should be of the form "Xchg64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:65:1: comment on exported function Xchguintptr should be of the form "Xchguintptr ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:68:1: comment on exported function Load8 should be of the form "Load8 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:74:1: comment on exported function And8 should be of the form "And8 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:77:1: comment on exported function Or8 should be of the form "Or8 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:80:1: comment on exported function And should be of the form "And ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:83:1: comment on exported function Or should be of the form "Or ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:88:1: comment on exported function Cas64 should be of the form "Cas64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:91:1: comment on exported function CasRel should be of the form "CasRel ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:94:1: comment on exported function Store should be of the form "Store ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:97:1: comment on exported function Store8 should be of the form "Store8 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:100:1: comment on exported function Store64 should be of the form "Store64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:103:1: comment on exported function StoreRel should be of the form "StoreRel ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:106:1: comment on exported function StoreRel64 should be of the form "StoreRel64 ..."
/usr/lib/go/src/runtime/internal/atomic/atomic_amd64.go:109:1: comment on exported function StoreReluintptr should be of the form "StoreReluintptr ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:11:1: comment on exported function Cas should be of the form "Cas ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:14:1: comment on exported function Casp1 should be of the form "Casp1 ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:17:1: comment on exported function Casuintptr should be of the form "Casuintptr ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:20:1: comment on exported function Storeuintptr should be of the form "Storeuintptr ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:23:1: comment on exported function Loaduintptr should be of the form "Loaduintptr ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:26:1: comment on exported function Loaduint should be of the form "Loaduint ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:31:1: comment on exported function Loadint64 should be of the form "Loadint64 ..."
/usr/lib/go/src/runtime/internal/atomic/stubs.go:34:1: comment on exported function Xaddint64 should be of the form "Xaddint64 ..."
/usr/lib/go/src/runtime/internal/sys/intrinsics_common.go:47:1: comment on exported function Len64 should be of the form "Len64 ..."
/usr/lib/go/src/runtime/internal/sys/stubs.go:15:1: comment on exported const StackGuardMultiplier should be of the form "StackGuardMultiplier ..."
/usr/lib/go/src/runtime/internal/sys/sys.go:5:1: package comment should be of the form "Package sys ..."
/usr/lib/go/src/runtime/trace/annotation.go:11:2: a blank import should be only in a main or test package, or have a comment justifying it
/usr/lib/go/src/sort/sort.go:10:1: comment on exported type Interface should be of the form "Interface ..." (with optional leading article)
/usr/lib/go/src/strconv/atof.go:314:1: receiver name d should be consistent with previous receiver name b for decimal
/usr/lib/go/src/strconv/eisel_lemire.go:77:3: should replace retExp2 += 1 with retExp2++
/usr/lib/go/src/strconv/eisel_lemire.go:152:3: should replace retExp2 += 1 with retExp2++
/usr/lib/go/src/strconv/internal_test.go:9:27: exported func NewDecimal returns unexported type *strconv.decimal, which can be annoying to use
/usr/lib/go/src/strings/replace.go:44:1: receiver name b should be consistent with previous receiver name r for Replacer
/usr/lib/go/src/sync/waitgroup.go:35:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/syscall/exec_linux.go:50:2: struct field UidMappings should be UIDMappings
/usr/lib/go/src/syscall/exec_linux.go:628:6: func writeUidGidMappings should be writeUIDGidMappings
/usr/lib/go/src/syscall/exec_unix.go:123:2: struct field Uid should be UID
/usr/lib/go/src/syscall/exec_unix.go:256:1: comment on exported function ForkExec should be of the form "ForkExec ..."
/usr/lib/go/src/syscall/lsf_linux.go:13:1: comment on exported function LsfStmt should be of the form "LsfStmt ..."
/usr/lib/go/src/syscall/lsf_linux.go:18:1: comment on exported function LsfJump should be of the form "LsfJump ..."
/usr/lib/go/src/syscall/lsf_linux.go:23:1: comment on exported function LsfSocket should be of the form "LsfSocket ..."
/usr/lib/go/src/syscall/lsf_linux.go:49:1: comment on exported function SetLsfPromisc should be of the form "SetLsfPromisc ..."
/usr/lib/go/src/syscall/lsf_linux.go:74:1: comment on exported function AttachLsf should be of the form "AttachLsf ..."
/usr/lib/go/src/syscall/lsf_linux.go:82:1: comment on exported function DetachLsf should be of the form "DetachLsf ..."
/usr/lib/go/src/syscall/syscall_unix.go:223:1: comment on exported var SocketDisableIPv6 should be of the form "SocketDisableIPv6 ..."
/usr/lib/go/src/syscall/syscall_unix.go:239:2: struct field ZoneId should be ZoneID
/usr/lib/go/src/syscall/timestruct.go:9:1: comment on exported function TimespecToNsec should be of the form "TimespecToNsec ..."
/usr/lib/go/src/syscall/ztypes_linux_amd64.go:106:2: struct field Uid should be UID
/usr/lib/go/src/syscall/ztypes_linux_amd64.go:272:2: struct field Uid should be UID
/usr/lib/go/src/testing/testing.go:1712:6: func parseCpuList should be parseCPUList
/usr/lib/go/src/testing/iotest/logger_test.go:72:34: error strings should not be capitalized or end with punctuation or a newline
/usr/lib/go/src/text/scanner/scanner.go:26:1: comment on exported type Position should be of the form "Position ..." (with optional leading article)
/usr/lib/go/src/text/tabwriter/tabwriter.go:197:1: comment on exported method Writer.Init should be of the form "Init ..."
/usr/lib/go/src/text/tabwriter/tabwriter.go:424:1: comment on exported const Escape should be of the form "Escape ..."
/usr/lib/go/src/text/template/exec_test.go:229:5: error var myError should have name of the form errFoo
/usr/lib/go/src/text/template/exec_test.go:1305:5: error var alwaysError should have name of the form errFoo
/usr/lib/go/src/text/template/parse/parse.go:37:1: comment on exported type Mode should be of the form "Mode ..." (with optional leading article)
/usr/lib/go/src/time/format.go:394:5: error var atoiError should have name of the form errFoo
/usr/lib/go/src/time/zoneinfo.go:355:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/time/zoneinfo_read.go:110:5: error var badData should have name of the form errFoo
/usr/lib/go/src/time/zoneinfo_read.go:129:9: if block ends with a return statement, so drop this else and outdent its block
/usr/lib/go/src/time/zoneinfo_read.go:287:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/time/zoneinfo_read.go:293:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
/usr/lib/go/src/unsafe/unsafe.go:5:1: package comment should not have leading space
@robpike
Copy link
Contributor

robpike commented Apr 19, 2021

The Go linter is a heuristic that is not required to be followed in all cases. Some of these may be improvements worth making, but the fact that golint complains is not in itself justification for change. So please, do not just blindly do everything on this list. Many are just not important. Saying +=1 instead of ++, for instance, is a matter of style, not a red flag.

But for changes that genuinely improve the code rather than just silence a nag, some of these may be worth doing.

You are seeing here the kind of thing that explains in part why the Go compiler does not have warnings.

@perillo
Copy link
Contributor Author

perillo commented Apr 19, 2021

@robpike, thanks for the suggestion.

After go1.17 is released I will start with "if block ends with a return statement, so drop this else and outdent its block".

However I think it is a good think to have a consistent coding style in the std module and tests. It does not matter if it is not the coding style suggested by golint; it just have to be consistent.

@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 20, 2021
@toothrot toothrot added this to the Backlog milestone Apr 20, 2021
@mvdan
Copy link
Member

mvdan commented May 8, 2021

Given that #38968 was accepted, I don't think we should have umbrella issues about fixing golint issues. If it makes sense to fix some of its warnings, just send CLs - that's always welcome. Straightforward code quality improvements like that usually don't need an issue to be tracked with.

We're not going to fix all of them nor enforce the tool, because it wouldn't make sense and the tool is deprecated. Thanks!

@mvdan mvdan closed this as completed May 8, 2021
@golang golang locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants