Skip to content

x/build/cmd/releasebot: for major releases, also check the first minor release milestone exists #44404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Feb 19, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Member

I noticed that GopherBot hadn't closed #44346 even though CL 293411 was submitted. I figured out the problem by looking at its logs and seeing:

2021/02/19 00:26:09 Failed to apply minor release milestone to issue 44346: no minor milestone found for release series 1.16
2021/02/19 00:26:09 Failed to apply minor release milestone to issue 44358: no minor milestone found for release series 1.16
2021/02/19 00:26:09 Failed to apply minor release milestone to issue 44402: no minor milestone found for release series 1.16

GopherBot failed to apply a minor release milestone to the issue, and so the issue's milestone didn't match the CL's branch goX.Y version. GopherBot didn't apply the minor release milestone because the milestone didn't exist.

I fixed the immediate issue by creating the Go1.16.1 milestone.

I'll also send a CL to add the missing step of creating the next major and minor milestone to our internal release process, so that this won't happen again for future major Go releases.

CC @golang/release, @ianlancetaylor.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 19, 2021
@dmitshur dmitshur added this to the Unreleased milestone Feb 19, 2021
@dmitshur dmitshur self-assigned this Feb 19, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 19, 2021
@dmitshur dmitshur changed the title x/build/cmd/releasebot: should also create the next minor release milestone x/build/cmd/releasebot: for major releases, also check the next minor release milestone exists Feb 19, 2021
@dmitshur dmitshur changed the title x/build/cmd/releasebot: for major releases, also check the next minor release milestone exists x/build/cmd/releasebot: for major releases, also check the first minor release milestone exists Feb 19, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/294249 mentions this issue: cmd/releasebot: add check for "create first minor release milestone" step

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants