Skip to content

runtime: darwin builders failing on metrics changes #42218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prattmic opened this issue Oct 26, 2020 · 3 comments
Closed

runtime: darwin builders failing on metrics changes #42218

prattmic opened this issue Oct 26, 2020 · 3 comments
Labels
FrozenDueToAge OS-Darwin release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Go1.16

Comments

@prattmic
Copy link
Member

All of the darwin builders are failing on one of the metrics changes that just went in.

The failing commit is one of golang.org/cl/246971, golang.org/cl/246972, golang.org/cl/246973.

I am attempting to repro on a gomote.

cc @mknyszek @aclements @golang/release
@prattmic prattmic added this to the Go1.16 milestone Oct 26, 2020
@dmitshur dmitshur added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Oct 26, 2020
@prattmic
Copy link
Member Author

https://golang.org/cl/246971 is the specific failing CL.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/265157 mentions this issue: runtime: make sysMemStats' methods nosplit

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/265158 mentions this issue: runtime: revert commits 8ebc58..a8b28eb

@golang golang locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Darwin release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot