Skip to content

x/pkgsite: markdown in "overview" should behave like markdown on Github #41179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
echarrod opened this issue Sep 2, 2020 · 2 comments
Closed

x/pkgsite: markdown in "overview" should behave like markdown on Github #41179

echarrod opened this issue Sep 2, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
Unreleased

Comments

@echarrod
Copy link

echarrod commented Sep 2, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/getyoti/yoti-go-sdk/v3?tab=overview

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Screenshot

image

What did you do?

Loaded package overeview

What did you expect to see?

The list items to be formatted like they are on GitHub (https://github.com/getyoti/yoti-go-sdk):
image

i.e. even though they're listed as 1)s, they display sequentially when the markdown is rendered:

What did you see instead?

As in "Screenshot" section, numbers are all 1)s, rather than sequential
@gopherbot gopherbot added this to the Unreleased milestone Sep 2, 2020
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Sep 2, 2020
@dmitshur
Copy link
Member

dmitshur commented Sep 2, 2020

Issue #39297 may be relevant.

/cc @julieqiu

@julieqiu
Copy link
Member

julieqiu commented Sep 2, 2020

Thanks @echarrod for the feedback. Let's discuss more on #39297. Closing as a duplicate.

@julieqiu julieqiu closed this as completed Sep 2, 2020
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@echarrod @dmitshur @julieqiu @gopherbot