Skip to content

crypto/tls: improve ConnectionState docs #37572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
divjotarora opened this issue Feb 28, 2020 · 3 comments
Closed

crypto/tls: improve ConnectionState docs #37572

divjotarora opened this issue Feb 28, 2020 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@divjotarora
Copy link

Issue #36736 proposes using tls.ConnectionState for extra verification during the TLS handshake. Before this is done, it would be good to improve documentation for certain fields to make it clear what the format of each field is. For example, one open question from me is whether or not each chain in VerifiedChains is of the form peer->issuer-of-peer->issuer-of-issuer-of-peer->...
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Feb 28, 2020
@divjotarora divjotarora mentioned this issue Feb 28, 2020
Closed
@FiloSottile FiloSottile changed the title Documentation improvements for tls.ConnectionState crypto/tls: improve ConnectionState docs Feb 28, 2020
@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 28, 2020
@FiloSottile FiloSottile added this to the Go1.15 milestone Feb 28, 2020
@FiloSottile FiloSottile self-assigned this Feb 28, 2020
@odeke-em
Copy link
Member

You might be interested in this change @retornam.

@ianlancetaylor
Copy link
Contributor

Moving milestone to backlog.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.15, Backlog Jun 16, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/239744 mentions this issue: crypto/tls: expand the ConnectionState docs

@golang golang locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@FiloSottile @ianlancetaylor @odeke-em @gopherbot @divjotarora