Skip to content

Proposal: Go 2: database/sql: Do what ever is required to make mysql queries truly cancellable. #28074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pjebs opened this issue Oct 8, 2018 · 2 comments
Closed

Proposal: Go 2: database/sql: Do what ever is required to make mysql queries truly cancellable. #28074

pjebs opened this issue Oct 8, 2018 · 2 comments
Labels
FrozenDueToAge Proposal
Milestone
Proposal

Comments

@pjebs
Copy link
Contributor

pjebs commented Oct 8, 2018

The way database/sql is designed is currently flawed. I found out the issue is more serious that I previously thought.

This proposal is a deferment to higher minds to solve this issue because I don't have expertise to even explain it here:

See: go-sql-driver/mysql#863 (comment)

See: #27962
@gopherbot gopherbot added this to the Proposal milestone Oct 8, 2018
@pjebs pjebs mentioned this issue Oct 8, 2018
Closed
@pjebs
Copy link
Contributor Author

pjebs commented Oct 8, 2018

@julienschmidt can explain in more detail.

@kardianos
Copy link
Contributor

I'm aware of this issue. With connectors, adding a single dedicated canceller connection is possible now. However, the fundamental problem is MySQL problem, not database/sql .

@golang golang locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
3 participants
@kardianos @pjebs @gopherbot