Skip to content

net: TestSpecialDomainName can hang indefinitely #13939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mundaym opened this issue Jan 13, 2016 · 5 comments
Closed

net: TestSpecialDomainName can hang indefinitely #13939

mundaym opened this issue Jan 13, 2016 · 5 comments
Labels
FrozenDueToAge

Comments

@mundaym
Copy link
Member

mundaym commented Jan 13, 2016

The DNS test TestSpecialDomainName can hang indefinitely because it sends a DNS request using UDP and waits for a response without specifying a timeout.

The easiest fix would be to add a timeout to the call to exchange so that the test fails quickly with a nice error message if the request gets lost or is ignored. For example:

msg, err := exchange(server, tt.name, tt.qtype, 3 * time.Second)
@bradfitz
Copy link
Contributor

You want to send a change, or do you want us to?

@mundaym
Copy link
Member Author

mundaym commented Jan 13, 2016

I'm happy to send a change.

@mundaym
Copy link
Member Author

mundaym commented Jan 14, 2016

CL sent https://go-review.googlesource.com/18661

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/18661 mentions this issue.

@danp
Copy link
Contributor

danp commented Jan 15, 2016

Ref #13295

Might be nice to not involve the network for these at some point.

@golang golang locked and limited conversation to collaborators Jan 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danp @bradfitz @gopherbot @mundaym