Skip to content

Commit fde6868

Browse files
author
Bryan C. Mills
committed
os/signal: in TestStop, skip the final "unexpected signal" check for SIGUSR1 on Android
In CL 226138, I updated TestStop to have more uniform behavior for its signals. However, that test seems to always fail for SIGUSR1 on the Android ARM builders. I'm not sure what's special about Android for this particular case, but let's skip the test to unbreak the builders while I investigate. For #38165 Updates #33174 Change-Id: I35a70346cd9757a92acd505a020bf95e6871405c Reviewed-on: https://go-review.googlesource.com/c/go/+/226458 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 16237b2 commit fde6868

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/os/signal/signal_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,9 @@ func TestStop(t *testing.T) {
355355
quiesce()
356356
select {
357357
case s := <-c:
358+
if sig == syscall.SIGUSR1 && s == syscall.SIGUSR1 && runtime.GOOS == "android" {
359+
testenv.SkipFlaky(t, 38165)
360+
}
358361
t.Fatalf("unexpected signal %v", s)
359362
default:
360363
// nothing to read - good

0 commit comments

Comments
 (0)