Skip to content

Commit fd36763

Browse files
mknyszekbradfitz
authored andcommitted
Revert "runtime: scavenge memory upon allocating from scavenged memory"
This reverts commit 8e093e7 (CL 159500). Reason for revert: Increases memory allocation latency in certain situations. Fixes #31679. Change-Id: I15e02c53a58009fd907b619b8649de2cdeb29ef0 Reviewed-on: https://go-review.googlesource.com/c/go/+/174102 Run-TryBot: Michael Knyszek <[email protected]> Reviewed-by: Austin Clements <[email protected]>
1 parent 438b1a5 commit fd36763

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

src/runtime/mheap.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,16 +1198,6 @@ HaveSpan:
11981198
// heap_released since we already did so earlier.
11991199
sysUsed(unsafe.Pointer(s.base()), s.npages<<_PageShift)
12001200
s.scavenged = false
1201-
1202-
// Since we allocated out of a scavenged span, we just
1203-
// grew the RSS. Mitigate this by scavenging enough free
1204-
// space to make up for it.
1205-
//
1206-
// Also, scavengeLargest may cause coalescing, so prevent
1207-
// coalescing with s by temporarily changing its state.
1208-
s.state = mSpanManual
1209-
h.scavengeLargest(s.npages * pageSize)
1210-
s.state = mSpanFree
12111201
}
12121202
s.unusedsince = 0
12131203

0 commit comments

Comments
 (0)