Skip to content

Commit fb6f38d

Browse files
dmitshurgopherbot
authored andcommitted
cmd/distpack: test for .DS_Store files in all directories
macOS may write a .DS_Store file to any directory at any time in the general case, unfortunately. Expand test rules to catch them no matter where they may appear. For #24904. Change-Id: I98a2bb5d0ae2ab3a191ff87b33d6f8048ca39aa8 Reviewed-on: https://go-review.googlesource.com/c/go/+/514898 Reviewed-by: Russ Cox <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent f719de0 commit fb6f38d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/cmd/distpack/test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var srcRules = []testRule{
2626
{name: "go/VERSION"},
2727
{name: "go/src/cmd/go/main.go"},
2828
{name: "go/src/bytes/bytes.go"},
29-
{name: "go/.DS_Store", exclude: true},
29+
{name: "**/.DS_Store", exclude: true},
3030
{name: "go/.git", exclude: true},
3131
{name: "go/.gitattributes", exclude: true},
3232
{name: "go/.github", exclude: true},
@@ -44,7 +44,7 @@ var zipRules = []testRule{
4444
{name: "go/src/cmd/go/main.go"},
4545
{name: "go/src/bytes/bytes.go"},
4646

47-
{name: "go/.DS_Store", exclude: true},
47+
{name: "**/.DS_Store", exclude: true},
4848
{name: "go/.git", exclude: true},
4949
{name: "go/.gitattributes", exclude: true},
5050
{name: "go/.github", exclude: true},
@@ -73,7 +73,7 @@ var modRules = []testRule{
7373
{name: "golang.org/toolchain@*/src/cmd/go/main.go"},
7474
{name: "golang.org/toolchain@*/src/bytes/bytes.go"},
7575

76-
{name: "golang.org/toolchain@*/.DS_Store", exclude: true},
76+
{name: "**/.DS_Store", exclude: true},
7777
{name: "golang.org/toolchain@*/.git", exclude: true},
7878
{name: "golang.org/toolchain@*/.gitattributes", exclude: true},
7979
{name: "golang.org/toolchain@*/.github", exclude: true},

0 commit comments

Comments
 (0)