Merge branch 'master' of https://github.com/golang/go into invalid-char-url-scheme

Author: cgopalan

AUTHORS

@@ -418,7 +418,7 @@ Eivind Uggedal <[email protected]>
 Elbert Fliek <[email protected]>
 Eldar Rakhimberdin <[email protected]>
 Elena Grahovac <[email protected]>
-Elias Naur <[email protected]>
+Elias Naur <[email protected]> <[email protected]>
 Elliot Morrison-Reed <[email protected]>
 Emerson Lin <[email protected]>
 Emil Hessman <[email protected]>
@@ -1304,6 +1304,7 @@ Sven Almgren <[email protected]>
 Sylvain Zimmer <[email protected]>
 Syohei YOSHIDA <[email protected]>
 Szabolcs Nagy <[email protected]>
+Taavi Kivisik <[email protected]>
 Tad Fisher <[email protected]>
 Tad Glines <[email protected]>
 Taj Khattra <[email protected]>

CONTRIBUTORS

@@ -25,6 +25,7 @@
 # Please keep the list sorted.
 
 Aamir Khan <[email protected]>
+Aaron Cannon <[email protected]>
 Aaron France <[email protected]>
 Aaron Jacobs <[email protected]>
 Aaron Kemp <[email protected]>
@@ -188,6 +189,7 @@ Andy Finkenstadt <[email protected]>
 Andy Lindeman <[email protected]>
 Andy Maloney <[email protected]>
 Andy Walker <[email protected]>
+Andzej Maciusovic <[email protected]>
 Anfernee Yongkun Gui <[email protected]>
 Angelo Bulfone <[email protected]>
 Anh Hai Trinh <[email protected]>
@@ -553,6 +555,7 @@ Dong-hee Na <[email protected]>
 Donovan Hide <[email protected]>
 Doug Anderson <[email protected]>
 Doug Fawley <[email protected]>
+Douglas Danger Manley <[email protected]>
 Drew Flower <[email protected]>
 Drew Hintz <[email protected]>
 Duncan Holm <[email protected]>
@@ -575,7 +578,7 @@ Eivind Uggedal <[email protected]>
 Elbert Fliek <[email protected]>
 Eldar Rakhimberdin <[email protected]>
 Elena Grahovac <[email protected]>
-Elias Naur <[email protected]>
+Elias Naur <[email protected]> <[email protected]>
 Elliot Morrison-Reed <[email protected]>
 Emerson Lin <[email protected]>
 Emil Hessman <[email protected]>
@@ -633,6 +636,7 @@ Fannie Zhang <[email protected]>
 Fatih Arslan <[email protected]>
 Fazal Majid <[email protected]>
 Fazlul Shahriar <[email protected]>
+Federico Bond <[email protected]>
 Federico Simoncelli <[email protected]>
 Fedor Indutny <[email protected]>
 Felipe Oliveira <[email protected]>
@@ -661,6 +665,7 @@ Frederik Ring <[email protected]>
 Fredrik Enestad <[email protected]>
 Fredrik Forsmo <[email protected]>
 Fredrik Wallgren <[email protected]>
+Frew Schmidt <[email protected]>
 Frithjof Schulze <[email protected]> <[email protected]>
 Frits van Bommel <[email protected]>
 Fumitoshi Ukai <[email protected]>
@@ -714,8 +719,9 @@ GitHub User @mkishere (224617) <[email protected]>
 GitHub User @OlgaVlPetrova (44112727) <[email protected]>
 GitHub User @pityonline (438222) <[email protected]>
 GitHub User @pytimer (17105586) <[email protected]>
+GitHub User @saitarunreddy (21041941) <[email protected]>
 GitHub User @shogo-ma (9860598) <[email protected]>
-GitHub User @tkivisik (13732144) <taavi.kivisik@gmail.com>
+GitHub User @tell-k (26263) <ffk2005@gmail.com>
 GitHub User @uhei (2116845) <[email protected]>
 GitHub User @uropek (39370426) <[email protected]>
 Giulio Iotti <[email protected]>
@@ -733,6 +739,7 @@ Greg Steuck <[email protected]>
 Greg Ward <[email protected]>
 Grégoire Delattre <[email protected]>
 Gregory Man <[email protected]>
+Guilherme Caruso <[email protected]>
 Guilherme Garnier <[email protected]>
 Guilherme Goncalves <[email protected]>
 Guilherme Rezende <[email protected]>
@@ -895,6 +902,7 @@ Jason Wangsadinata <[email protected]>
 Javier Kohen <[email protected]>
 Javier Segura <[email protected]>
 Jay Conrod <[email protected]>
+Jay Taylor <[email protected]>
 Jay Weisskopf <[email protected]>
 Jean de Klerk <[email protected]>
 Jean-André Santoni <[email protected]>
@@ -1020,13 +1028,15 @@ Jostein Stuhaug <[email protected]>
 JP Sugarbroad <[email protected]>
 JT Olds <[email protected]>
 Juan Carlos <[email protected]>
+Juan Pablo Civile <[email protected]>
 Jude Pereira <[email protected]>
 Jukka-Pekka Kekkonen <[email protected]>
 Julia Hansbrough <[email protected]>
 Julian Kornberger <[email protected]>
 Julian Pastarmov <[email protected]>
 Julian Phillips <[email protected]>
 Julie Qiu <[email protected]>
+Julien Kauffmann <[email protected]>
 Julien Salleyron <[email protected]>
 Julien Schmidt <[email protected]>
 Julio Montes <[email protected]>
@@ -1282,6 +1292,7 @@ Maxim Ushakov <[email protected]>
 Maxime de Roucy <[email protected]>
 Máximo Cuadros Ortiz <[email protected]>
 Maxwell Krohn <[email protected]>
+Maya Rashish <[email protected]>
 Mayank Kumar <[email protected]>
 Meir Fischer <[email protected]>
 Meng Zhuo <[email protected]>
@@ -1458,6 +1469,7 @@ Pallat Anchaleechamaikorn <[email protected]>
 Paolo Giarrusso <[email protected]>
 Paolo Martini <[email protected]>
 Parker Moore <[email protected]>
+Parminder Singh <[email protected]>
 Pascal S. de Kloe <[email protected]>
 Pat Moroney <[email protected]>
 Patrick Crosby <[email protected]>
@@ -1504,6 +1516,7 @@ Peter Armitage <[email protected]>
 Peter Bourgon <[email protected]>
 Peter Collingbourne <[email protected]>
 Peter Conerly <[email protected]>
+Peter Dotchev <[email protected]>
 Peter Froehlich <[email protected]>
 Peter Gonda <[email protected]>
 Peter Hoyes <[email protected]>
@@ -1554,6 +1567,7 @@ Quentin Perez <[email protected]>
 Quentin Renard <[email protected]>
 Quentin Smith <[email protected]>
 Quinn Slack <[email protected]>
+Quinten Yearsley <[email protected]>
 Quoc-Viet Nguyen <[email protected]>
 Radek Sohlich <[email protected]>
 Radu Berinde <[email protected]>
@@ -1627,6 +1641,7 @@ Ron Hashimoto <[email protected]>
 Ron Minnich <[email protected]>
 Ross Chater <[email protected]>
 Ross Light <[email protected]> <[email protected]>
+Ross Smith II <[email protected]>
 Rowan Marshall <[email protected]>
 Rowan Worth <[email protected]>
 Rudi Kramer <[email protected]>
@@ -1681,13 +1696,17 @@ Scott Mansfield <[email protected]>
 Scott Schwartz <[email protected]>
 Scott Van Woudenberg <[email protected]>
 Sean Burford <[email protected]>
+Sean Chen <[email protected]>
 Sean Chittenden <[email protected]>
 Sean Christopherson <[email protected]>
 Sean Dolphin <[email protected]>
 Sean Harger <[email protected]>
 Sean Rees <[email protected]>
+Sebastiaan van Stijn <[email protected]>
+Sebastian Schmidt <[email protected]>
 Sebastien Binet <[email protected]>
 Sébastien Paolacci <[email protected]>
+Sebastien Williams-Wynn <[email protected]>
 Seiji Takahashi <[email protected]>
 Sergei Skorobogatov <[email protected]>
 Sergey 'SnakE' Gromov <[email protected]>
@@ -1773,6 +1792,7 @@ Sven Blumenstein <[email protected]>
 Sylvain Zimmer <[email protected]>
 Syohei YOSHIDA <[email protected]>
 Szabolcs Nagy <[email protected]>
+Taavi Kivisik <[email protected]>
 Tad Fisher <[email protected]>
 Tad Glines <[email protected]>
 Tadas Valiukas <[email protected]>
@@ -1889,6 +1909,7 @@ Val Polouchkine <[email protected]>
 Vega Garcia Luis Alfonso <[email protected]>
 Venil Noronha <[email protected]>
 Veselkov Konstantin <[email protected]>
+Viacheslav Poturaev <[email protected]>
 Victor Chudnovsky <[email protected]>
 Victor Vrantchan <[email protected]>
 Vignesh Ramachandra <[email protected]>
@@ -1962,6 +1983,7 @@ Yestin Sun <[email protected]>
 Yesudeep Mangalapilly <[email protected]>
 Yissakhar Z. Beck <[email protected]>
 Yo-An Lin <[email protected]>
+Yohei Takeda <[email protected]>
 Yongjian Xu <[email protected]>
 Yorman Arias <[email protected]>
 Yoshiyuki Kanno <[email protected]> <[email protected]>

doc/go1.12.html

@@ -113,6 +113,18 @@ <h3 id="vet"><code>go tool vet</code> no longer supported</h3>
 </pre>
 </p>
 
+<h3 id="tour">Tour</h3>
+
+<p> <!-- CL 152657 -->
+The Go tour is no longer included in the main binary distribution. To
+run the tour locally, instead of running <code>go</code> <code>tool</code> <code>tour</code>,
+manually install it:
+<pre>
+go install golang.org/x/tour
+tour
+</pre>
+</p>
+
 <h3 id="gocache">Build cache requirement</h3>
 
 <p>
@@ -139,6 +151,12 @@ <h3 id="cgo">Cgo</h3>
 	for more information.
 </p>
 
+<p><!-- CL 152657 -->
+  Mangled C names are no longer accepted in packages that use Cgo. Use the Cgo
+  names instead. For example, use the documented cgo name <code>C.char</code>
+  rather than the mangled name <code>_Ctype_char</code> that cgo generates.
+</p>
+
 <h3 id="modules">Modules</h3>
 
 <p><!-- CL 148517 -->
@@ -163,10 +181,10 @@ <h3 id="modules">Modules</h3>
 
 <p><!-- CL 147282, 147281 -->
   The <code>go</code> directive in a <code>go.mod</code> file now indicates the
-  version of the language used by the files within that module, and
-  <code>go</code> <code>mod</code> <code>tidy</code> sets it to the
-  current release (<code>go</code> <code>1.12</code>) if no existing
-  version is present.
+  version of the language used by the files within that module.
+  It will be set to the current release
+  (<code>go</code> <code>1.12</code>) if no existing version is
+  present.
   If the <code>go</code> directive for a module specifies a
   version <em>newer</em> than the toolchain in use, the <code>go</code> command
   will attempt to build the packages regardless, and will note the mismatch only if
@@ -226,6 +244,23 @@ <h3 id="compiler">Compiler toolchain</h3>
 </pre>
 </p>
 
+<p><!-- CL 153477 -->
+  Wrappers generated by the compiler to implement method expressions
+  are no longer reported
+  by <a href="/pkg/runtime/#CallersFrames"><code>runtime.CallersFrames</code></a>
+  and <a href="/pkg/runtime/#Stack"><code>runtime.Stack</code></a>. They
+  are also not printed in panic stack traces.
+
+  This change aligns the <code>gc</code> toolchain to match
+  the <code>gccgo</code> toolchain, which already elided such wrappers
+  from stack traces.
+
+  Clients of these APIs might need to adjust for the missing
+  frames. For code that must interoperate between 1.11 and 1.12
+  releases, you can replace the method expression <code>x.M</code>
+  with the function literal <code>func (...) { x.M(...) } </code>.
+</p>
+
 <p><!-- CL 144340 -->
   The compiler now accepts a <code>-lang</code> flag to set the Go language
   version to use. For example, <code>-lang=go1.8</code> causes the compiler to
@@ -239,9 +274,9 @@ <h3 id="compiler">Compiler toolchain</h3>
   except for calls that simultaneously cross between Go and
   assembly <em>and</em> cross a package boundary. If linking results
   in an error like "relocation target not defined for ABIInternal (but
-  is defined for ABI0)", please refer to help section of the ABI
-  design document.
-  <!-- TODO(austin): Link to the design doc. -->
+  is defined for ABI0)", please refer to the
+  <a href="https://github.com/golang/proposal/blob/master/design/27539-internal-abi.md#compatibility">compatibility section</a>
+  of the ABI design document.
 </p>
 
 <p><!-- CL 145179 -->
@@ -276,6 +311,11 @@ <h3 id="godoc"><code>godoc</code> and <code>go</code> <code>doc</code></h3>
   as the <code>godoc</code> command line used to do.
 </p>
 
+<p><!-- CL 140959 -->
+  <code>go</code> <code>doc</code> also now includes the <code>-src</code> flag,
+  which will show the target's source code.
+</p>
+
 <h3 id="trace">Trace</h3>
 
 <p><!-- CL 60790 -->
@@ -329,6 +369,19 @@ <h2 id="runtime">Runtime</h2>
   yet supported on Windows.
 </p>
 
+<p><!-- CL 158337 -->
+  Go 1.12 improves the accuracy of memory profiles by fixing
+  overcounting of large heap allocations.
+</p>
+
+<p><!-- CL 159717 -->
+  Tracebacks, <code>runtime.Caller</code>,
+  and <code>runtime.Callers</code> no longer include
+  compiler-generated initialization functions.  Doing a traceback
+  during the initialization of a global variable will now show a
+  function named <code>PKG.init.ializers</code>.
+</p>
+
 <h2 id="library">Core library</h2>
 
 <h3 id="tls_1_3">TLS 1.3</h3>
@@ -438,7 +491,9 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
   <dd>
     <p><!-- CL 146258 -->
       TLS 1.2 clients and servers will now advertise and accept RSA-PSS
-      signature algorithms for use with regular RSA public keys.
+      signature algorithms for use with regular RSA public keys. Certain
+      insecure certificate keys (including 512-bit RSA keys) will
+      now cause a handshake failure if RSA-PSS is selected.
     </p>
 
     <p><!-- CL 143177 -->
@@ -844,6 +899,12 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
       <code>executing "tmpl" at <.very.deep.context.value.notpresent>: map has no entry for key "notpresent"</code>
     </p>
 
+  <dd>
+    <p><!-- CL 143097 -->
+      If a user-defined function called by a template panics, the
+      panic is now caught and returned as an error by
+      the <code>Execute</code> or <code>ExecuteTemplate</code> method.
+    </p>
 </dl><!-- text/template -->
 
 <dl id="unsafe"><dt><a href="/pkg/unsafe/">unsafe</a></dt>

doc/install.html

@@ -271,6 +271,39 @@ <h2 id="testing">Test your installation</h2>
 </p>
 
 
+<h2 id="extra_versions">Installing extra Go versions</h2>
+
+<p>
+It may be useful to have multiple Go versions installed on the same machine, for
+example, to ensure that a package's tests pass on multiple Go versions.
+Once you have one Go version installed, you can install another (such as 1.10.7)
+as follows:
+</p>
+
+<pre>
+$ go get golang.org/dl/go1.10.7
+$ go1.10.7 download
+</pre>
+
+<p>
+The newly downloaded version can be used like <code>go</code>:
+</p>
+
+<pre>
+$ go1.10.7 version
+go version go1.10.7 linux/amd64
+</pre>
+
+<p>
+All Go versions available via this method are listed on
+<a href="https://godoc.org/golang.org/dl#pkg-subdirectories">the download page</a>.
+You can find where each of these extra Go versions is installed by looking
+at its <code>GOROOT</code>; for example, <code>go1.10.7 env GOROOT</code>.
+To uninstall a downloaded version, just remove its <code>GOROOT</code> directory
+and the <code>goX.Y.Z</code> binary.
+</p>
+
+
 <h2 id="uninstall">Uninstalling Go</h2>
 
 <p>

misc/cgo/test/issue29748.go

@@ -0,0 +1,22 @@
+// Copyright 2019 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Error handling a struct initializer that requires pointer checking.
+// Compilation test only, nothing to run.
+
+package cgotest
+
+// typedef struct { char **p; } S29748;
+// static int f29748(S29748 *p) { return 0; }
+import "C"
+
+var Vissue29748 = C.f29748(&C.S29748{
+	nil,
+})
+
+func Fissue299748() {
+	C.f29748(&C.S29748{
+		nil,
+	})
+}