Skip to content

Commit ed2f913

Browse files
labogerbradfitz
authored andcommitted
syscall: update comments for x/sys migration
The comments in this package state that users should be migrating code that uses the syscall package to its corresponding package in x/sys. However, the syscall.Signal and syscall.Errno types and the syscall.SysProcAttr struct is not defined in the x/sys package and still need to be referenced from within syscall. This adds a change to the comments to clarify that the migration will need to continue to use some references to syscall for now. Fixes #19560 Change-Id: I8abb96b93bea90070ce461da16dc7bcf7b4b29c1 Reviewed-on: https://go-review.googlesource.com/39450 Reviewed-by: Rob Pike <[email protected]>
1 parent a7b51cf commit ed2f913

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/syscall/syscall.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@
2222
// Go repository should be migrated to use the corresponding
2323
// package in the golang.org/x/sys repository. That is also where updates
2424
// required by new systems or versions should be applied.
25-
// See https://golang.org/s/go1.4-syscall for more information.
25+
// Signal, Errno and SysProcAttr are not yet available in
26+
// golang.org/x/sys and must still be referenced from the
27+
// syscall package. See https://golang.org/s/go1.4-syscall
28+
// for more information.
2629
//
2730
package syscall
2831

0 commit comments

Comments
 (0)